From owner-freebsd-stable@FreeBSD.ORG Sat Dec 30 17:08:57 2006 Return-Path: X-Original-To: freebsd-stable@freebsd.org Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 769BB16A407 for ; Sat, 30 Dec 2006 17:08:57 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id 464D413C44B for ; Sat, 30 Dec 2006 17:08:57 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 59B1147C9E; Sat, 30 Dec 2006 12:08:56 -0500 (EST) Date: Sat, 30 Dec 2006 17:08:56 +0000 (GMT) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Karol Kwiatkowski In-Reply-To: <45969487.1020806@orchid.homeunix.org> Message-ID: <20061230170358.K50974@fledge.watson.org> References: <20061230035722.L39715@thebighonker.lerctr.org> <20061230151933.P18740@fledge.watson.org> <20061230093730.I47579@thebighonker.lerctr.org> <20061230160353.K18740@fledge.watson.org> <45969487.1020806@orchid.homeunix.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Max Laier , freebsd-stable@freebsd.org Subject: Re: 6.2-PRE: Fatal Trap? X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Dec 2006 17:08:57 -0000 On Sat, 30 Dec 2006, Karol Kwiatkowski wrote: >>>> It looks like the attached patch was missed in the MFC I just pointed at. >>>> Could you try applying it? >>>> >>>> You can also fetch it from: >>>> >>>> >>>> http://www.watson.org/~robert/freebsd/20061230-20061230-tcp_pcb_fix.diff >>>> >>> >>> Normally, I'd be more than happy to, but, given: 1) the box is 300+ miles >>> away 2) I do NOT have access to remote hands again till Tuesday (Holiday) >>> 3) this is my firewall between all my services and the rest of the world >>> and if down, I'm off the air :( >>> >>> I wish I could, but can't afford to be down for the 5 days :( >>> >>> Thanks for the diagnosis, however, as I was going nuts. >> >> I've gone ahead and MFC'd the missing tcp_subr.c patch and the change now >> appears stable on by 6-STABLE test box. I'd appreciate it if other people >> experiencing the panic could slide forward to confirm (or perhaps less >> ideally, not confirm) that this fixes the problem for them also. > > The link is slightly broken, I've found the patch here: > > http://www.watson.org/~robert/freebsd/20061230-tcp_pcb_fix.diff Thanks, sorry about that! > Applied, recompiled the kernel - no more panic :) > > Thanks Robert nad Max. If there's anything else needed let me know. I've committed the fix, so with any luck life will be better. > P.S. out of curiosity - now that I have configured kernel with DDB and KDB > options, is there any performance penalty of running such kernel? No, it shouldn't really have any effect on performance. The one thing to watch out for is that your system will no longer reboot automatically on a panic, as it will drop to the debugger, by default. You can change this by setting debug.debugger_on_panic to 0, in which case you will likely want to set debug.trace_on_panic to 1 so it prints a stack trace before rebooting (which is often sufficient, combined with the trap frame and panic message to debug the problem). Right now these are sysctls, not tunables, but you can change the default using options KDB_UNATTENDED (which flips the default to not entering the debugger and rebooting) and options KDB_TRACE (which causes a trace to be printed on panic by default). Probably they should also be tunables so that loader.conf entries will work. Robert N M Watson Computer Laboratory University of Cambridge