From owner-cvs-all@FreeBSD.ORG Tue Mar 24 03:11:45 2009 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 93794106564A; Tue, 24 Mar 2009 03:11:45 +0000 (UTC) (envelope-from mezz7@cox.net) Received: from eastrmmtao103.cox.net (eastrmmtao103.cox.net [68.230.240.9]) by mx1.freebsd.org (Postfix) with ESMTP id B77A98FC08; Tue, 24 Mar 2009 03:11:44 +0000 (UTC) (envelope-from mezz7@cox.net) Received: from eastrmimpo01.cox.net ([68.1.16.119]) by eastrmmtao103.cox.net (InterMail vM.7.08.02.01 201-2186-121-102-20070209) with ESMTP id <20090324031144.OYOF21373.eastrmmtao103.cox.net@eastrmimpo01.cox.net>; Mon, 23 Mar 2009 23:11:44 -0400 Received: from localhost ([68.103.37.153]) by eastrmimpo01.cox.net with bizsmtp id WrBj1b0063JFCbG02rBjBs; Mon, 23 Mar 2009 23:11:44 -0400 X-Authority-Analysis: v=1.0 c=1 a=mAHCJQ1VLlkA:10 a=d2nfdjRH2mkA:10 a=6I5d2MoRAAAA:8 a=kviXuzpPAAAA:8 a=LFdJdKRYpruv8xj1NjIA:9 a=mF9WmDxO1NhWzYDhu-4A:7 a=mUV7TffzjZ5zo9vVAy9zUIw9cCMA:4 a=LY0hPdMaydYA:10 a=SV7veod9ZcQA:10 a=4vB-4DCPJfMA:10 a=bVyUOuyIwbIyvvNk:21 a=cR-H7kgqDEWgtvxw:21 X-CM-Score: 0.00 Date: Mon, 23 Mar 2009 21:11:59 -0600 To: "Wesley Shields" From: "Jeremy Messenger" Content-Type: text/plain; format=flowed; delsp=yes; charset=utf-8 MIME-Version: 1.0 References: <200903240023.n2O0NVBb013624@repoman.freebsd.org> <49C84088.9020505@FreeBSD.org> <20090324021518.GC1292@atarininja.org> Content-Transfer-Encoding: 7bit Message-ID: In-Reply-To: <20090324021518.GC1292@atarininja.org> User-Agent: Opera Mail/9.64 (Linux) Cc: cvs-ports@freebsd.org, Doug Barton , cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/net-im/libpurple Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Mar 2009 03:11:46 -0000 On Mon, 23 Mar 2009 20:15:18 -0600, Wesley Shields wrote: > On Mon, Mar 23, 2009 at 07:08:08PM -0700, Doug Barton wrote: >> Wesley Shields wrote: >> > wxs 2009-03-24 00:23:31 UTC >> > >> > FreeBSD ports repository >> > >> > Modified files: >> > net-im/libpurple Makefile >> > Log: >> > - Chase devel/silc-toolkit update. >> > >> > Revision Changes Path >> > 1.58 +1 -1 ports/net-im/libpurple/Makefile >> > >> > >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-im/libpurple/Makefile.diff?&r1=1.57&r2=1.58&f=h >> >> Since silc is off by default (and therefore the package won't change), >> was this necessary? > > There are two viewpoints to this: > > 1) The option is off by default so the package won't change, and thus > PORTREVISION doesn't need to be bumped. > > 2) Not bumping PORTREVISION may cause the port to misbehave if it's > built with old libraries. None of that above, but you did it correct to bump it to avoid users' libpurple broke for can't find old library. BTW: Does not matter if the option is off, still need to be bump. Cheers, Mezz > I don't know which (if any) is the right answer, but I went with option > #2 in this case. I'm interested in knowing what the official thing to > do is because I can see both sides of this debate. > > -- WXS -- mezz7@cox.net - mezz@FreeBSD.org FreeBSD GNOME Team http://www.FreeBSD.org/gnome/ - gnome@FreeBSD.org