From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Nov 24 13:50:01 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4C0F110656A7 for ; Tue, 24 Nov 2009 13:50:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 255E48FC27 for ; Tue, 24 Nov 2009 13:50:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id nAODo11s028369 for ; Tue, 24 Nov 2009 13:50:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id nAODo1VJ028368; Tue, 24 Nov 2009 13:50:01 GMT (envelope-from gnats) Resent-Date: Tue, 24 Nov 2009 13:50:01 GMT Resent-Message-Id: <200911241350.nAODo1VJ028368@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Ruben van Staveren Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 33EEC1065670 for ; Tue, 24 Nov 2009 13:45:33 +0000 (UTC) (envelope-from ruben@helium.verweg.com) Received: from helium.verweg.com (tunnel41.ipv6.xs4all.nl [IPv6:2001:888:10:29::2]) by mx1.freebsd.org (Postfix) with ESMTP id A42208FC17 for ; Tue, 24 Nov 2009 13:45:32 +0000 (UTC) Received: from helium.verweg.com (ruben@localhost.verweg.com [127.0.0.1]) by helium.verweg.com (8.14.3/8.14.3) with ESMTP id nAODjQll011366 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 24 Nov 2009 14:45:31 +0100 (CET) (envelope-from ruben@helium.verweg.com) Received: (from ruben@localhost) by helium.verweg.com (8.14.3/8.14.3/Submit) id nAODjQMK011365; Tue, 24 Nov 2009 14:45:26 +0100 (CET) (envelope-from ruben) Message-Id: <200911241345.nAODjQMK011365@helium.verweg.com> Date: Tue, 24 Nov 2009 14:45:26 +0100 (CET) From: Ruben van Staveren To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Ruben van Staveren Subject: ports/140829: www/tomcat55 rc.d script is broken and will not stop tomcat process X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Ruben van Staveren List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Nov 2009 13:50:01 -0000 >Number: 140829 >Category: ports >Synopsis: www/tomcat55 rc.d script is broken and will not stop tomcat process >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Tue Nov 24 13:50:00 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Ruben van Staveren >Release: FreeBSD 7.2-STABLE i386 >Organization: >Environment: System: FreeBSD helium.verweg.com 7.2-STABLE FreeBSD 7.2-STABLE #76: Sun Nov 15 19:57:49 CET 2009 root@helium.verweg.com:/usr/obj/usr/cvsup/7-stable/src/sys/HELIUM-SMP i386 >Description: Due to various jvms in FreeBSD /usr/local/bin/java is a symlink to the configured one. tomcat55's rc.d script does not take that into account for the stop action and thus will not terminate/restart tomcat55. The attached patch corrects this misbehaviour >How-To-Repeat: /usr/local/etc/rc.d/tomcat55 stop will complain the process is not running, even if it is. >Fix: --- tomcat55.diff begins here --- diff -nur www/tomcat55.orig/Makefile www/tomcat55/Makefile --- www/tomcat55.orig/Makefile 2008-10-26 12:26:11.000000000 +0100 +++ www/tomcat55/Makefile 2009-11-24 14:13:22.000000000 +0100 @@ -7,6 +7,7 @@ PORTNAME= tomcat PORTVERSION= 5.5.27 +PORTREVISION= 1 CATEGORIES= www java MASTER_SITES= ${MASTER_SITE_APACHE} MASTER_SITE_SUBDIR= tomcat/tomcat-5/v${PORTVERSION}/bin diff -nur www/tomcat55.orig/files/tomcat55.sh.in www/tomcat55/files/tomcat55.sh.in --- www/tomcat55.orig/files/tomcat55.sh.in 2007-10-01 00:04:02.000000000 +0200 +++ www/tomcat55/files/tomcat55.sh.in 2009-11-23 17:38:03.000000000 +0100 @@ -109,7 +109,7 @@ if [ -f $pidfile ]; then read rc_pid junk < $pidfile if [ ! -z "$rc_pid" ]; then - procname=`ps -o ucomm= -p $rc_pid` + procname=`ps -o command= -p $rc_pid | cut -f 1 -d ' '` fi fi if [ -z "$procname" ]; then --- tomcat55.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: