From owner-freebsd-bugs@FreeBSD.ORG Tue Dec 7 21:30:21 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C2FEC16A4CF for ; Tue, 7 Dec 2004 21:30:21 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id DC2B143D45 for ; Tue, 7 Dec 2004 21:30:13 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.1/8.13.1) with ESMTP id iB7LUDAR008542 for ; Tue, 7 Dec 2004 21:30:13 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.1/8.13.1/Submit) id iB7LUDqZ008532; Tue, 7 Dec 2004 21:30:13 GMT (envelope-from gnats) Resent-Date: Tue, 7 Dec 2004 21:30:13 GMT Resent-Message-Id: <200412072130.iB7LUDqZ008532@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Alexander Melkov Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 412BA16A4CE for ; Tue, 7 Dec 2004 21:21:51 +0000 (GMT) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id 285A043D48 for ; Tue, 7 Dec 2004 21:21:51 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id iB7LLoG0047972 for ; Tue, 7 Dec 2004 21:21:50 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id iB7LLo7Y047971; Tue, 7 Dec 2004 21:21:50 GMT (envelope-from nobody) Message-Id: <200412072121.iB7LLo7Y047971@www.freebsd.org> Date: Tue, 7 Dec 2004 21:21:50 GMT From: Alexander Melkov To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Subject: bin/74823: ftpd should not use warn(x) more carefully when used from inetd [patch] X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Dec 2004 21:30:22 -0000 >Number: 74823 >Category: bin >Synopsis: ftpd should not use warn(x) more carefully when used from inetd [patch] >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Dec 07 21:30:13 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Alexander Melkov >Release: 5.3 >Organization: >Environment: FreeBSD melkov.ru 5.3-RELEASE FreeBSD 5.3-RELEASE #1: Tue Nov 9 14:59:22 MSK 2004 spamtrap@melkov.ru:/usr/obj/usr/src/sys/MELKOV i386 >Description: When ftpd is invoked from inetd, every call to warn(x), err(x) functions produces an output that is not compliant with rfc959, etc. This particularly happens when incorrect start-up parameters specified (that's silly, yet my internet service provider's ftp server is configured that way right now ;) ). >How-To-Repeat: Write ftp stream tcp nowait root /usr/libexec/ftpd ftpd -AWK into /etc/inetd.conf and restart inetd Run ftp localhost 'ftp' program will fail to establish connection Run nc localhost 21 see ftpd: illegal option -- K ftpd: unknown flag -K ignored 220 ...... FTP server (Version 6.00LS) ready. >Fix: ftpd.c is 1.163 diff ftpd.c.1.163 ftpd.c 286a287 > struct stat st; 290a292,296 > > if (fstat(0, &st) == 0 && (st.st_mode & S_IFMT) == S_IFSOCK) { > extern char *__progname; > __progname = "220-"; > } - this is not a graceful solution, yet a warnx call from getopt function should be covered somehow. >Release-Note: >Audit-Trail: >Unformatted: