From owner-freebsd-current@FreeBSD.ORG Wed Dec 31 05:41:29 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9699316A4CE for ; Wed, 31 Dec 2003 05:41:29 -0800 (PST) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.185]) by mx1.FreeBSD.org (Postfix) with ESMTP id E4D3443D2D for ; Wed, 31 Dec 2003 05:41:27 -0800 (PST) (envelope-from max@love2party.net) Received: from [212.227.126.179] (helo=mrelayng9.kundenserver.de) by moutng.kundenserver.de with esmtp (Exim 3.35 #1) id 1AbgbG-0005la-00 for current@freebsd.org; Wed, 31 Dec 2003 14:41:26 +0100 Received: from [217.83.13.134] (helo=vampire.homelinux.org) by mrelayng9.kundenserver.de with asmtp (Exim 3.35 #1) id 1AbgbF-00084O-00 for current@freebsd.org; Wed, 31 Dec 2003 14:41:25 +0100 Received: (qmail 7632 invoked from network); 31 Dec 2003 13:45:46 -0000 Received: from unknown (HELO fbsd52.laiers.local) (192.168.4.88) by 192.168.4.1 with SMTP; 31 Dec 2003 13:45:46 -0000 From: Max Laier To: Mark Huizer , current@freebsd.org Date: Wed, 31 Dec 2003 14:41:23 +0100 User-Agent: KMail/1.5.4 References: <20031231130800.GB59239@eeyore.local.dohd.org> <200312311421.25383.max@love2party.net> <20031231132651.GC59239@eeyore.local.dohd.org> In-Reply-To: <20031231132651.GC59239@eeyore.local.dohd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200312311441.23719.max@love2party.net> X-Provags-ID: kundenserver.de abuse@kundenserver.de auth:e28873fbe4dbe612ce62ab869898ff08 Subject: Re: kern.osreldate and EAI_NODATA deprecation X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Dec 2003 13:41:29 -0000 On Wednesday 31 December 2003 14:26, Mark Huizer wrote: > > __FreeBSD_version is defined in sys/sys/param.h. The closest for your > > case is: 501112 from October 16th. > > http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/sys/param.h > > > > I'd rather suggest using an unconditional patch which introduces #ifdef > > EAI_NODATA where required. That is future save (as the comment notes that > > EAI_NODATA will go forever on Apr 23th). > > Well, that's tougher, since EAI_NODATA is defined (it's defined to be > EAI_NODATA). > Hmm... > would this work? I'm not too 100% secure about preprocessing stuff. > If this should work, I could try to get it included in the normal kaffe > tree. > > #if defined(EAI_NODATA) && EAI_NODATA != EAI_NONAME > ... > #endif Other question, does it hurt you that EAI_NODATA == EAI_NONAME? I'd not think so ... so why borther?! But yes, the syntax is okay ... consider extra parentheses for the second expression. > Perhaps I should put a defined(__FREEBSD__) somewhere in there as well. > > #if !defined(__FREEBSD__) || (defined(EAI_NODATA) && EAI_NODATA != > EAI_NONAME) > > Something like that? As long as you keep it locally in the *FreeBSD* ports tree there is no point in checking that twice. If you plan to submit patches to the original authors you might want to double check which platforms have EAI_NODATA and which don't (as the commit messages hints that there might be others w/o EAI_NODATA). autoconf and friends ... -- Best regards, | max@love2party.net Max Laier | ICQ #67774661 http://pf4freebsd.love2party.net/ | mlaier@EFnet #DragonFlyBSD