From owner-cvs-all Mon Apr 1 17:10:14 2002 Delivered-To: cvs-all@freebsd.org Received: from k6.locore.ca (k6.locore.ca [198.96.117.170]) by hub.freebsd.org (Postfix) with ESMTP id C652F37B419; Mon, 1 Apr 2002 17:10:01 -0800 (PST) Received: (from jake@localhost) by k6.locore.ca (8.11.6/8.11.6) id g321BVn07363; Mon, 1 Apr 2002 20:11:31 -0500 (EST) (envelope-from jake) Date: Mon, 1 Apr 2002 20:11:30 -0500 From: Jake Burkholder To: "M. Warner Losh" Cc: dillon@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 critical.c src/sys/i386/include cpufunc.h critical.h src/sys/i386/isa apic_vector.s icu_vector.s src/sys/kern kern_fork.c kern_proc.c kern_switch.c src/sys/alpha/alpha critical.c src/sys/alpha/include cpufunc.h ... Message-ID: <20020401201130.K207@locore.ca> References: <200204012351.g31NpO890339@freefall.freebsd.org> <20020401.175136.106024419.imp@village.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20020401.175136.106024419.imp@village.org>; from imp@village.org on Mon, Apr 01, 2002 at 05:51:36PM -0700 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Apparently, On Mon, Apr 01, 2002 at 05:51:36PM -0700, M. Warner Losh said words to the effect of; > In message: <200204012351.g31NpO890339@freefall.freebsd.org> > Matt Dillon writes: > : Note: In general, developers should not gratuitously move declarations out > : of sub-blocks. They are where they are for reasons of structure, grouping, > : readability, compiler-localizability, and to avoid developer-introduced bugs > : similar to several found in recent years in the VFS and VM code. > > Yes. Style(9) says don't do this unless the code is really complicated: > > Parts of a for loop may be left empty. Do not put declarations inside > blocks unless the routine is unusually complicated. > > I suspect that the stuff you are working on is complicated enough to > justify their use. Style(9) doesn't say never do this. I personally don't like it, but I think you are correct. Jake To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message