From owner-cvs-all Mon Oct 1 14:33: 4 2001 Delivered-To: cvs-all@freebsd.org Received: from obsecurity.dyndns.org (adsl-64-165-226-227.dsl.lsan03.pacbell.net [64.165.226.227]) by hub.freebsd.org (Postfix) with ESMTP id 2D88337B410; Mon, 1 Oct 2001 14:32:53 -0700 (PDT) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id A3F2D66BD5; Mon, 1 Oct 2001 14:32:52 -0700 (PDT) Date: Mon, 1 Oct 2001 14:32:52 -0700 From: Kris Kennaway To: David O'Brien Cc: Bruce Evans , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libedit Makefile chared.c chared.h common.c editline.3 editrc.5 el.c el.h emacs.c hist.c hist.h history.c key.c key.h makelist map.c map.h parse.c parse.h prompt.c Message-ID: <20011001143252.A85386@xor.obsecurity.org> References: <200110010841.f918fRR58241@freefall.freebsd.org> <20011001221352.K79142-100000@delplex.bde.org> <20011001104103.C94881@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="mYCpIKhGyMATD0i+" Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20011001104103.C94881@dragon.nuxi.com>; from obrien@FreeBSD.org on Mon, Oct 01, 2001 at 10:41:03AM -0700 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --mYCpIKhGyMATD0i+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 01, 2001 at 10:41:03AM -0700, David O'Brien wrote: > On Mon, Oct 01, 2001 at 10:23:18PM +1000, Bruce Evans wrote: > > > Log: > > > + Sync with NetBSD, bringing in feature enhancements. > > > + Convert to ANSI-C function definitions > > > + style(9) > > > > > > Submitted by: kris > >=20 > > Please don't mix style changes with feature changes. Most of the chang= es > > seem to be to reformat from indent 4 to indent 8. The feature changes = are > > difficult to see. >=20 > I was not happy that the patch available combined all three of these into > one patch. But it was either commit that patch as-is, or it was never > going to get committed. There is code that will be turned on soon that > requires the NetBSD chagnes. Since this commit syncs up to NetBSD, it would have been really difficult to go through and separate style and functional changes. There are approximately 4 years worth of commits included here, because libedit is actively maintained in NetBSD. Kris --mYCpIKhGyMATD0i+ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (FreeBSD) Comment: For info see http://www.gnupg.org iD8DBQE7uOEEWry0BWjoQKURApJdAKDtsK+c3ftSWBpUpaQHn0a4d3VPsACgnmCB ifYelSfSRmkrAJwUygPzKc4= =f7vE -----END PGP SIGNATURE----- --mYCpIKhGyMATD0i+-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message