From owner-cvs-all Fri Apr 28 15:56:18 2000 Delivered-To: cvs-all@freebsd.org Received: from scientia.demon.co.uk (scientia.demon.co.uk [212.228.14.13]) by hub.freebsd.org (Postfix) with ESMTP id 7402137B723; Fri, 28 Apr 2000 15:56:06 -0700 (PDT) (envelope-from ben@scientia.demon.co.uk) Received: from strontium.scientia.demon.co.uk ([192.168.91.36] ident=exim) by scientia.demon.co.uk with esmtp (Exim 3.12 #1) id 12lI7Q-0005xU-00; Fri, 28 Apr 2000 22:16:12 +0100 Received: (from ben) by strontium.scientia.demon.co.uk (Exim 3.12 #7) id 12lI7P-000LSZ-00; Fri, 28 Apr 2000 22:16:11 +0100 Date: Fri, 28 Apr 2000 22:16:11 +0100 From: Ben Smithurst To: Guy Helmer Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/cron/lib env.c Message-ID: <20000428221611.D17098@strontium.scientia.demon.co.uk> References: <200004281531.IAA14106@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0i In-Reply-To: <200004281531.IAA14106@freefall.freebsd.org> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Guy Helmer wrote: > Use consistent types in sizeof when malloc'ing memory for the > environment. - p = (char **) malloc((count+1) * sizeof(char *)); /* 1 for the NULL */ + p = (char **) malloc((count+1) * sizeof(char **)); /* 1 for the NULL */ uh, I think this change is wrong. As p is a 'char **' you are allocating space for 'char *' values, not 'char **' values. Not that it really matters, except from a style point of view. -- Ben Smithurst / ben@scientia.demon.co.uk / PGP: 0x99392F7D To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message