From owner-freebsd-current@FreeBSD.ORG Thu Feb 14 14:17:22 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id EC59D342; Thu, 14 Feb 2013 14:17:22 +0000 (UTC) (envelope-from mi+thun@aldan.algebra.com) Received: from smtp02.lnh.mail.rcn.net (smtp02.lnh.mail.rcn.net [207.172.157.102]) by mx1.freebsd.org (Postfix) with ESMTP id 9E821736; Thu, 14 Feb 2013 14:17:22 +0000 (UTC) Received: from mr16.lnh.mail.rcn.net ([207.172.157.36]) by smtp02.lnh.mail.rcn.net with ESMTP; 14 Feb 2013 09:17:23 -0500 Received: from smtp01.lnh.mail.rcn.net (smtp01.lnh.mail.rcn.net [207.172.4.11]) by mr16.lnh.mail.rcn.net (MOS 4.3.4-GA) with ESMTP id CFY18215; Thu, 14 Feb 2013 09:17:21 -0500 X-Auth-ID: anat Received: from pool-71-187-31-131.nwrknj.fios.verizon.net (HELO [192.168.1.8]) ([71.187.31.131]) by smtp01.lnh.mail.rcn.net with ESMTP; 14 Feb 2013 09:17:21 -0500 Message-ID: <511CF1F1.5070204@aldan.algebra.com> Date: Thu, 14 Feb 2013 09:17:21 -0500 From: "Mikhail T." User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130209 Thunderbird/17.0.2 MIME-Version: 1.0 To: Tom Evans Subject: Re: ports include /etc/src.conf? i.e. graphics/libfpx References: <511B662C.7030602@zedat.fu-berlin.de> <511B874A.7080901@kbh.biglobe.ne.jp> <511BBDAD.1080806@zedat.fu-berlin.de> <511CD83C.107@aldan.algebra.com> <511CE2AD.8050506@aldan.algebra.com> In-Reply-To: X-Mailman-Approved-At: Thu, 14 Feb 2013 14:19:06 +0000 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: Kimmo Paasiala , "free >> Current FreeBSD" , "O. Hartmann" , Ports FreeBSD , Yamaya Takashi X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Feb 2013 14:17:23 -0000 14.02.2013 08:55, Tom Evans написав(ла): > On Thu, Feb 14, 2013 at 1:12 PM, Mikhail T. wrote: >> > I may sound defensive here, but I'll still repeat, that "this singular port" >> > (and I do, in fact, have other ones like it) started using bsd.lib.mk 5 >> > years before src.conf (and its man-page) was added to the tree. >> > This is true. But what is the bug, that the port's Makefile.bsd was > not updated on the introduction of src.conf to DTRT (and no-one > noticed for 7 years), or that the purpose of src.conf has been > mistakenly documented for 7 years? I think, the bug is either in documentation or implementation of src.conf (if it had to be implemented at all, that is) -- there was never (and still is not) any suggestion, that bsd.{prog,lib}.mk are not supposed to be used by other people's software. Maybe, if the file is really meant to be used by *world and *kernel targets, the knob should've been _WITH_SRCONF -- and added to the environment by src/Makefile? Because, forget ports for a second, what if my own little project uses bsd.prog.mk -- because Makefiles using it tend to fit in a window without scrolling? I'd say, the documentation should be updated to state, that src.conf will affect anything, that uses bsd.*.mk family of makefiles, unless _WITHOUT_SRCCONF is set. The entire /usr/src as well as "some of the ports" may then be listed as examples of the areas affected. This will reflect reality and help avoid frustration that O. Hartmann went through. -mi