From owner-cvs-all Mon Mar 12 19: 8:10 2001 Delivered-To: cvs-all@freebsd.org Received: from gndrsh.dnsmgr.net (GndRsh.dnsmgr.net [198.145.92.4]) by hub.freebsd.org (Postfix) with ESMTP id 696ED37B71A; Mon, 12 Mar 2001 19:08:02 -0800 (PST) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.9.3/8.9.3) id TAA41551; Mon, 12 Mar 2001 19:07:26 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <200103130307.TAA41551@gndrsh.dnsmgr.net> Subject: Re: cvs commit: src/sys/netinet ip_output.c In-Reply-To: <20010312160321.B95497@mollari.cthul.hu> from Kris Kennaway at "Mar 12, 2001 04:03:21 pm" To: kris@obsecurity.org (Kris Kennaway) Date: Mon, 12 Mar 2001 19:07:26 -0800 (PST) Cc: phk@critter.freebsd.dk (Poul-Henning Kamp), luigi@info.iet.unipi.it (Luigi Rizzo), joe@tao.org.uk (Josef Karthauser), iedowse@FreeBSD.org (Ian Dowse), cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org X-Mailer: ELM [version 2.4ME+ PL54 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > On Mon, Mar 12, 2001 at 09:58:53AM -0800, Rodney W. Grimes wrote: > > > In message <200103112315.AAA79776@info.iet.unipi.it>, Luigi Rizzo writes: > > > >> It's been in since last October. I guess that noone's using dummynet in > > > >> -current at the moment. > > > > > > > >it is just another example that for some things the "commit to -current > > > >first, wait at least 3 days before MFC" is totally useless and if > > > >we want to have these things tested we need to commit them where > > > >they are used. > > > > > > The "wait at least 3 days" is for catching obious blunders. > > > > > > If you want testing in -stable, publish a patch for stable and > > > ask people to test it for you. > > > > Perhaps this should be stated as a requirement in the handbook? Drop > > the 3 days thing, it doesn't seem to be doing us any good anyway. > > Nah, that's a bad idea. As PHK states, waiting before merging to > -stable catches stupid bonehead mistakes, which happen too frequently > to ignore this. I suspect that a published and tested patch to -stable before an MFC would catch more ``bonehead mistakes'' than the 3 day wait does. -- Rod Grimes - KD7CAX @ CN85sl - (RWG25) rgrimes@gndrsh.dnsmgr.net To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message