From owner-cvs-all Mon Mar 12 19:34:58 2001 Delivered-To: cvs-all@freebsd.org Received: from obsecurity.dyndns.org (adsl-63-207-60-59.dsl.lsan03.pacbell.net [63.207.60.59]) by hub.freebsd.org (Postfix) with ESMTP id DC32D37B71A; Mon, 12 Mar 2001 19:34:52 -0800 (PST) (envelope-from kris@obsecurity.org) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 67CC266B6C; Mon, 12 Mar 2001 19:34:52 -0800 (PST) Date: Mon, 12 Mar 2001 19:34:52 -0800 From: Kris Kennaway To: "Rodney W. Grimes" Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet ip_output.c Message-ID: <20010312193452.A2927@mollari.cthul.hu> References: <20010312160321.B95497@mollari.cthul.hu> <200103130307.TAA41551@gndrsh.dnsmgr.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="x+6KMIRAuhnl3hBn" Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200103130307.TAA41551@gndrsh.dnsmgr.net>; from freebsd@gndrsh.dnsmgr.net on Mon, Mar 12, 2001 at 07:07:26PM -0800 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG --x+6KMIRAuhnl3hBn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 12, 2001 at 07:07:26PM -0800, Rodney W. Grimes wrote: > > On Mon, Mar 12, 2001 at 09:58:53AM -0800, Rodney W. Grimes wrote: > > > > In message <200103112315.AAA79776@info.iet.unipi.it>, Luigi Rizzo w= rites: > > > > >> It's been in since last October. I guess that noone's using dum= mynet in > > > > >> -current at the moment. > > > > > > > > > >it is just another example that for some things the "commit to -cu= rrent > > > > >first, wait at least 3 days before MFC" is totally useless and if > > > > >we want to have these things tested we need to commit them where > > > > >they are used. > > > >=20 > > > > The "wait at least 3 days" is for catching obious blunders. > > > >=20 > > > > If you want testing in -stable, publish a patch for stable and > > > > ask people to test it for you. > > >=20 > > > Perhaps this should be stated as a requirement in the handbook? Drop > > > the 3 days thing, it doesn't seem to be doing us any good anyway. > >=20 > > Nah, that's a bad idea. As PHK states, waiting before merging to > > -stable catches stupid bonehead mistakes, which happen too frequently > > to ignore this. >=20 > I suspect that a published and tested patch to -stable before an MFC > would catch more ``bonehead mistakes'' than the 3 day wait does. Okay, now I'm confused as to what you're advocating. Certainly, expecting people to manually apply and test patches for every MFC is too much. Most changes are too small to warrant that, but still carry a risk of breaking something obvious or non-obvious, that a brief testing period would stand the chance of catching. Kris --x+6KMIRAuhnl3hBn Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.4 (FreeBSD) Comment: For info see http://www.gnupg.org iD8DBQE6rZVcWry0BWjoQKURAm7GAJwMe5y3ZcROK16b50jkKIYclR6PhQCgj6ii NmSkVR7QIAJoiYi6nojTqcY= =fZAs -----END PGP SIGNATURE----- --x+6KMIRAuhnl3hBn-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message