From owner-svn-src-all@FreeBSD.ORG Thu Jan 3 18:57:51 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id ADFEE119; Thu, 3 Jan 2013 18:57:51 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 8ABD3B52; Thu, 3 Jan 2013 18:57:51 +0000 (UTC) Received: from [192.168.2.119] (host109-157-116-32.range109-157.btcentralplus.com [109.157.116.32]) by cyrus.watson.org (Postfix) with ESMTPSA id 0782F46B3F; Thu, 3 Jan 2013 13:57:49 -0500 (EST) Subject: Re: svn commit: r244899 - head/sys/mips/beri Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset=us-ascii From: "Robert N. M. Watson" In-Reply-To: <20130103100258.2e22763f@fubar.geek.nz> Date: Thu, 3 Jan 2013 18:57:48 +0000 Content-Transfer-Encoding: quoted-printable Message-Id: <7D95B3E5-5F9C-45D8-9C79-C0F6D4CE625D@FreeBSD.org> References: <201212311106.qBVB6chM016661@svn.freebsd.org> <20130102081746.5435db05@fubar.geek.nz> <20130102110856.7c280fd5@fubar.geek.nz> <0E1E1A5C-BB34-4B82-828F-6FEE770A6037@FreeBSD.org> <20130103100258.2e22763f@fubar.geek.nz> To: Andrew Turner X-Mailer: Apple Mail (2.1283) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jan 2013 18:57:51 -0000 On 2 Jan 2013, at 21:02, Andrew Turner wrote: >> This seemed to do the trick; what do you think of the attached? This >> isn't a board-specific change, so I dropped it into the common >> fdt_mips.c code. On the other hand, this left it a bit open as to >> what the right compatible=3D line to use was, so feedback there most >> welcome. >=20 > The patch looks good. =46rom my reading of [1] the compatible value > should be something like "mips,mips4k" as it's value is of the form > ",". >=20 > I have been thinking the best way of merging these almost identical > decode functions. Linux appears to do it by providing a per-controller > function that can translate between the interrupt spec and the > configuration allowing them to have a generic parsing function that > doesn't need to check if the controller is compatible. I would like us > to have something similar as it will remove the duplicate function. Sounds good on tweaking the compatible value -- I'll do that my local = tree and merge to head fairly soon. I've now finished adapting our = current suite of device drivers to use FDT, which took a couple of days = but was fairly painless. On combining countless overlapping implementations: sounds reasonable to = me. Having a single implementation of a default parsing function = certainly wouldn't hurt -- or a single implementation of a generic one. Thanks, Robert=