From owner-svn-src-all@FreeBSD.ORG Mon Jun 1 18:42:32 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from hub.FreeBSD.org (hub.freebsd.org [IPv6:2001:1900:2254:206c::16:88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 43EE6101; Mon, 1 Jun 2015 18:42:31 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Date: Mon, 1 Jun 2015 18:42:26 +0000 From: Glen Barber To: Jack F Vogel Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r283883 - in head/sys: dev/ixgbe modules/ixv Message-ID: <20150601184226.GC53056@hub.FreeBSD.org> References: <201506011743.t51HhZUP011379@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZmUaFz6apKcXQszQ" Content-Disposition: inline In-Reply-To: <201506011743.t51HhZUP011379@svn.freebsd.org> X-Operating-System: FreeBSD 11.0-CURRENT amd64 X-SCUD-Definition: Sudden Completely Unexpected Dataloss X-SULE-Definition: Sudden Unexpected Learning Event X-PEKBAC-Definition: Problem Exists, Keyboard Between Admin/Computer User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Jun 2015 18:42:32 -0000 --ZmUaFz6apKcXQszQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 01, 2015 at 05:43:35PM +0000, Jack F Vogel wrote: > Author: jfv > Date: Mon Jun 1 17:43:34 2015 > New Revision: 283883 > URL: https://svnweb.freebsd.org/changeset/base/283883 >=20 > Log: > Delta D2489 - Add SRIOV support to the Intel 10G driver. > =20 > NOTE: This is a technology preview, while it has undergone > development testing, Intel has not yet completed full > validation of the feature. It is being integrated for > early access and customer testing. >=20 > Modified: > head/sys/dev/ixgbe/if_ix.c > head/sys/dev/ixgbe/if_ixv.c > head/sys/dev/ixgbe/ix_txrx.c > head/sys/dev/ixgbe/ixgbe.h > head/sys/dev/ixgbe/ixgbe_mbx.h > head/sys/dev/ixgbe/ixgbe_vf.c > head/sys/modules/ixv/Makefile >=20 This breaks the build. Please revert until the change is properly build-tested. /usr/src/sys/dev/ixgbe/if_ix.c:233:2: error: use of undeclared identifier '= pci_init_iov_desc' DEVMETHOD(pci_init_iov, ixgbe_init_iov), ^ /usr/src/sys/sys/bus.h:649:19: note: expanded from macro 'DEVMETHOD' #define DEVMETHOD KOBJMETHOD ^ /usr/src/sys/sys/kobj.h:98:5: note: expanded from macro 'KOBJMETHOD' { &NAME##_desc, (kobjop_t) (1 ? FUNC : (NAME##_t *)NULL) } ^ :48:1: note: expanded from here pci_init_iov_desc ^ /usr/src/sys/dev/ixgbe/if_ix.c:233:2: error: expected expression /usr/src/sys/sys/bus.h:649:19: note: expanded from macro 'DEVMETHOD' #define DEVMETHOD KOBJMETHOD ^ /usr/src/sys/sys/kobj.h:98:52: note: expanded from macro 'KOBJMETHOD' { &NAME##_desc, (kobjop_t) (1 ? FUNC : (NAME##_t *)NULL) } ^ /usr/src/sys/dev/ixgbe/if_ix.c:233:2: error: use of undeclared identifier '= pci_init_iov_t' /usr/src/sys/sys/bus.h:649:19: note: expanded from macro 'DEVMETHOD' #define DEVMETHOD KOBJMETHOD ^ /usr/src/sys/sys/kobj.h:98:42: note: expanded from macro 'KOBJMETHOD' { &NAME##_desc, (kobjop_t) (1 ? FUNC : (NAME##_t *)NULL) } ^ :48:1: note: expanded from here pci_init_iov_t ^ /usr/src/sys/dev/ixgbe/if_ix.c:234:2: error: use of undeclared identifier '= pci_uninit_iov_desc'; did you mean 'pci_enable_io_desc'? DEVMETHOD(pci_uninit_iov, ixgbe_uninit_iov), ^ /usr/src/sys/sys/bus.h:649:19: note: expanded from macro 'DEVMETHOD' #define DEVMETHOD KOBJMETHOD ^ /usr/src/sys/sys/kobj.h:98:5: note: expanded from macro 'KOBJMETHOD' { &NAME##_desc, (kobjop_t) (1 ? FUNC : (NAME##_t *)NULL) } ^ :48:1: note: expanded from here pci_uninit_iov_desc ^ =2E/pci_if.h:125:27: note: 'pci_enable_io_desc' declared here extern struct kobjop_desc pci_enable_io_desc; ^ /usr/src/sys/dev/ixgbe/if_ix.c:234:2: error: expected expression DEVMETHOD(pci_uninit_iov, ixgbe_uninit_iov), ^ /usr/src/sys/sys/bus.h:649:19: note: expanded from macro 'DEVMETHOD' #define DEVMETHOD KOBJMETHOD ^ /usr/src/sys/sys/kobj.h:98:52: note: expanded from macro 'KOBJMETHOD' { &NAME##_desc, (kobjop_t) (1 ? FUNC : (NAME##_t *)NULL) } /usr/src/sys/dev/ixgbe/if_ix.c:234:2: error: use of undeclared identifier '= pci_uninit_iov_t' /usr/src/sys/sys/bus.h:649:19: note: expanded from macro 'DEVMETHOD' #define DEVMETHOD KOBJMETHOD ^ /usr/src/sys/sys/kobj.h:98:42: note: expanded from macro 'KOBJMETHOD' { &NAME##_desc, (kobjop_t) (1 ? FUNC : (NAME##_t *)NULL) } ^ :48:1: note: expanded from here pci_uninit_iov_t ^ /usr/src/sys/dev/ixgbe/if_ix.c:235:2: error: use of undeclared identifier '= pci_add_vf_desc' DEVMETHOD(pci_add_vf, ixgbe_add_vf), ^ /usr/src/sys/sys/bus.h:649:19: note: expanded from macro 'DEVMETHOD' #define DEVMETHOD KOBJMETHOD ^ /usr/src/sys/sys/kobj.h:98:5: note: expanded from macro 'KOBJMETHOD' { &NAME##_desc, (kobjop_t) (1 ? FUNC : (NAME##_t *)NULL) } ^ :48:1: note: expanded from here pci_add_vf_desc ^ /usr/src/sys/dev/ixgbe/if_ix.c:235:2: error: expected expression /usr/src/sys/sys/bus.h:649:19: note: expanded from macro 'DEVMETHOD' #define DEVMETHOD KOBJMETHOD ^ /usr/src/sys/sys/kobj.h:98:52: note: expanded from macro 'KOBJMETHOD' { &NAME##_desc, (kobjop_t) (1 ? FUNC : (NAME##_t *)NULL) } ^ /usr/src/sys/dev/ixgbe/if_ix.c:235:2: error: use of undeclared identifier '= pci_add_vf_t' /usr/src/sys/sys/bus.h:649:19: note: expanded from macro 'DEVMETHOD' #define DEVMETHOD KOBJMETHOD ^ /usr/src/sys/sys/kobj.h:98:42: note: expanded from macro 'KOBJMETHOD' { &NAME##_desc, (kobjop_t) (1 ? FUNC : (NAME##_t *)NULL) } ^ :48:1: note: expanded from here pci_add_vf_t ^ /usr/src/sys/dev/ixgbe/if_ix.c:595:11: error: implicit declaration of funct= ion 'pci_iov_attach' is invalid in C99 [-Werror,-Wimplicit-function-declara= tion] error =3D pci_iov_attach(dev, pf_schema, vf_schema); ^ /usr/src/sys/dev/ixgbe/if_ix.c:660:6: error: implicit declaration of functi= on 'pci_iov_detach' is invalid in C99 [-Werror,-Wimplicit-function-declarat= ion] if (pci_iov_detach(dev) !=3D 0) { ^ /usr/src/sys/dev/ixgbe/if_ix.c:660:6: note: did you mean 'pci_iov_attach'? /usr/src/sys/dev/ixgbe/if_ix.c:595:11: note: 'pci_iov_attach' declared here error =3D pci_iov_attach(dev, pf_schema, vf_schema); ^ 11 errors generated. *** Error code 1 Stop. make[2]: stopped in /usr/obj/usr/src/sys/GENERIC *** Error code 1 Glen --ZmUaFz6apKcXQszQ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVbKeSAAoJEAMUWKVHj+KTFWQP+wZD+02ZXjh8QF9P3EO8gSWg 29DTZtkVO1u8VLe1dWJ0sjX4knMYdxCD55TbURFQwLBKFqlJFvPjVJT0z437eQE6 H+deyFijrMiN8hcwJhxh7w7i/puLiW2NDTLoZR00EJth1O+hFqm23IByojuLEY/V VHOwgOVQFt/BLM0N9mm9d/fb7ko4qtL40Mr+jT2Ih5uUvxLrp6JzOCcK9lPoVT/T FVHXjxLXD37MreBqwDF+ARkFi1as0VIDF3iHlCU4t9KH+xkCdADX9BSXlOxO4e5f aSoIASSDqVH4U3rLi5oYneC6SrCiUOYgTAxUHBgS9N1mjIHgYJYLxlgfqt3NrKWO /Fpvo2hP/WbGOo6/aP3CxAziK8tbvpnBNPbLz0HIsg8jbU4OihwTTqHEUI0W+iXe C61f2aL0yF/fmeB7rqS3Hc8Wj3N6ZZ84P4sgYo5bbcDZRMfFwo2jH8uAxcXJouxU U74YlOiNuE9JI3GuQIzzAJVMQEp9mnbKVQLJ8JIzW/XG1CK0h7yUMF8g8w1yi+Bl sSC53rcHDEuTYgsQrBAAFE6cCpvJ+VRhzEvggCMioQCqr6e+FEzyKZ3dMZYU0E4U GQ6p98LZyvAztdUstRLxT0O72XCyYZsO/tOIO72o5BwTSAg606HfSdngvChiW7lh xRVFwnPHZcDuBGG36ROB =ANj7 -----END PGP SIGNATURE----- --ZmUaFz6apKcXQszQ--