From owner-cvs-src@FreeBSD.ORG  Fri May 18 19:34:55 2007
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 9A3A316A406;
	Fri, 18 May 2007 19:34:55 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41])
	by mx1.freebsd.org (Postfix) with ESMTP id 7389513C45B;
	Fri, 18 May 2007 19:34:55 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l4IJYttl024877;
	Fri, 18 May 2007 19:34:55 GMT
	(envelope-from rwatson@repoman.freebsd.org)
Received: (from rwatson@localhost)
	by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l4IJYtnR024873;
	Fri, 18 May 2007 19:34:55 GMT (envelope-from rwatson)
Message-Id: <200705181934.l4IJYtnR024873@repoman.freebsd.org>
From: Robert Watson <rwatson@FreeBSD.org>
Date: Fri, 18 May 2007 19:34:55 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Cc: 
Subject: cvs commit: src/sys/nfsclient nfs_socket.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 18 May 2007 19:34:55 -0000

rwatson     2007-05-18 19:34:55 UTC

  FreeBSD src repository

  Modified files:
    sys/nfsclient        nfs_socket.c 
  Log:
  In nfs_down(), if rep can be NULL, which we test for, then we should
  lock and unlock conditionally, not just set the flag on it conditionally.
  In practice, this bug couldn't manifest, as in the current revision of
  the code, no callers pass a NULL rep.
  
  CID:            1416
  Found with:     Coverity Prevent(tm)
  
  Revision  Changes    Path
  1.153     +4 -3      src/sys/nfsclient/nfs_socket.c