From owner-svn-ports-head@FreeBSD.ORG Sun Jan 26 19:14:46 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 940511BD; Sun, 26 Jan 2014 19:14:46 +0000 (UTC) Received: from mail-ob0-x230.google.com (mail-ob0-x230.google.com [IPv6:2607:f8b0:4003:c01::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 244C21240; Sun, 26 Jan 2014 19:14:46 +0000 (UTC) Received: by mail-ob0-f176.google.com with SMTP id gq1so5629453obb.35 for ; Sun, 26 Jan 2014 11:14:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=Mq6NWsprGnz70Zw+vkyLVMR86fYbaFDQ8O+ZsVbLTJw=; b=pAOjbPfPKpTTSZZzPsJ3vggHrNbixZu4gAaH/3N0XZtMIWH3OGIeSti0UkDyoxRMSi IR/YdzlTcFOT9R+w4ZGJS8sp2g0vr5cFfv0vof7N3sguGun9TUmKcdjEQGC5KzAymow4 D+6CJVpIw2qjlom1MJuyoreVTZ0eXLnCiXsKiNyIbGbAZYwRhho6195bpQp/VRC2uufI 0g4up37DhBeKrehjIuwzLe12ZyaTJHPcdNMiMZRIhZZG8S7vQNbZYr06wsr4x50RRy5C Z/n6K14733LZd3qZLTdO/FCYPF/EUbrFsvbHaxC0TPNRRRYrX8aBKDu/Ac25XrgCUMvx xJ0g== MIME-Version: 1.0 X-Received: by 10.182.142.5 with SMTP id rs5mr2494771obb.39.1390763685454; Sun, 26 Jan 2014 11:14:45 -0800 (PST) Sender: andrej.zverev@gmail.com Received: by 10.182.252.233 with HTTP; Sun, 26 Jan 2014 11:14:45 -0800 (PST) In-Reply-To: <52E54E98.8080307@FreeBSD.org> References: <201401261514.s0QFEZY7093314@svn.freebsd.org> <52E54E98.8080307@FreeBSD.org> Date: Sun, 26 Jan 2014 23:14:45 +0400 X-Google-Sender-Auth: cc8sm5kCrcak-_IiscC-kLWPaYg Message-ID: Subject: Re: svn commit: r341219 - in head/www: xpi-twitterfox xpi-unplug xpi-urllink xpi-user_agent_switcher xpi-vimperator From: Andrej Zverev To: Renato Botelho Content-Type: text/plain; charset=ISO-8859-1 Cc: "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , "ports-committers@freebsd.org" , Martin Wilke X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jan 2014 19:14:46 -0000 On Sun, Jan 26, 2014 at 10:06 PM, Renato Botelho wrote: > On 26-01-2014 13:23, Andrej Zverev wrote: >> On Sun, Jan 26, 2014 at 7:14 PM, Martin Wilke wrote: >>> Author: miwi >>> Date: Sun Jan 26 15:14:34 2014 >>> New Revision: 341219 >>> URL: http://svnweb.freebsd.org/changeset/ports/341219 >>> QAT: https://qat.redports.org/buildarchive/r341219/ >>> >>> Log: >>> - Stage support >>> >>> >>> Modified: head/www/xpi-unplug/Makefile >>> ============================================================================== >>> --- head/www/xpi-unplug/Makefile Sun Jan 26 15:14:03 2014 (r341218) >>> +++ head/www/xpi-unplug/Makefile Sun Jan 26 15:14:34 2014 (r341219) >>> @@ -12,7 +12,6 @@ COMMENT= Converts embedded media to html >>> XPI_ID= unplug@compunach >>> XPI_NUM= 2254 >>> >>> -NO_STAGE= yes >>> xpi-post-extract: >>> ${FIND} ${WRKSRC} -type d -name CVS|${XARGS} ${RM} -rf >>> >>> >>> Modified: head/www/xpi-urllink/Makefile >> >> >> Can you at least run portlint and fix easy warnings in such commits? like >> "WARN: Makefile: [17]: possible use of "${FIND} ... ${XARGS} ${RM}" >> when "${FIND} ... -delete" will work" > > find -delete won't delete a not empty directory. And this find is only > looking for directories. While this is true, but distfile itself does not contain any CVS directories in this case ;-) 'easy fix'