From owner-freebsd-arch@FreeBSD.ORG  Mon Nov  7 22:26:15 2005
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
X-Original-To: freebsd-arch@freebsd.org
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8D03216A428;
	Mon,  7 Nov 2005 22:26:15 +0000 (GMT)
	(envelope-from scottl@samsco.org)
Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9FFF643D48;
	Mon,  7 Nov 2005 22:26:07 +0000 (GMT)
	(envelope-from scottl@samsco.org)
Received: from [192.168.254.14] (imini.samsco.home [192.168.254.14])
	(authenticated bits=0)
	by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id jA7MQ5Ht098578;
	Mon, 7 Nov 2005 15:26:06 -0700 (MST)
	(envelope-from scottl@samsco.org)
Message-ID: <436FD47D.2000802@samsco.org>
Date: Mon, 07 Nov 2005 15:26:05 -0700
From: Scott Long <scottl@samsco.org>
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US;
	rv:1.7.7) Gecko/20050416
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: John Baldwin <jhb@freebsd.org>
References: <20051106222359.GC46752@stack.nl>	<200511071118.35041.jhb@freebsd.org>	<20051107194424.GA35394@stack.nl>
	<200511071635.39323.jhb@freebsd.org>
In-Reply-To: <200511071635.39323.jhb@freebsd.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed 
	version=3.1.0
X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on pooker.samsco.org
Cc: Rink Springer <rink@stack.nl>, ed@fxq.nl, freebsd-arch@freebsd.org
Subject: Re: FreeBSD/xbox: updated 7.0 patchset
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Nov 2005 22:26:15 -0000

John Baldwin wrote:

> On Monday 07 November 2005 02:44 pm, Rink Springer wrote:
> 
>>Hi,
>>
>>OK, I've updated the patchset. Changes:
>>
>>- opt_xbox.h is now used instead of opt_global.h
>>- xboxfb.c should follow style(9) better
>>- boot_font.c is no longer patched
>>- 128MB XBOX-es should work too [1]
>>
>>It is fetchable from
>>http://rink.nu/downloads/xbox-patches/xbox-7-current.v2.diff
>>
>>Oh, and for John's comment: The reason pic16l.s is coded in assembly, was
>>that it was used extensively while debugging (it even resided in
>>locore.s for a while :-), as being able to change the LED's color is
>>immensely useful if you don't have a framebuffer working already :) This
>>is why I'd prefer to keep this file as-is.
> 
> 
> You do realize that you can call C functions from assembly, right? :)
> 

If this is the only remaining technical objection, then can it be
something that gets resolved after it goes into the tree?  It's code
that is segregated and private to the XBOX port, so it would be a shame
to make it stall this great work.

Scott