From owner-freebsd-bugs@FreeBSD.ORG Mon Feb 4 11:30:01 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AFB3F16A469 for ; Mon, 4 Feb 2008 11:30:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 8C46C13C4E5 for ; Mon, 4 Feb 2008 11:30:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m14BU1hL022399 for ; Mon, 4 Feb 2008 11:30:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m14BU18v022396; Mon, 4 Feb 2008 11:30:01 GMT (envelope-from gnats) Resent-Date: Mon, 4 Feb 2008 11:30:01 GMT Resent-Message-Id: <200802041130.m14BU18v022396@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jaakko Heinonen Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 853DC16A479 for ; Mon, 4 Feb 2008 11:29:28 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 717ED13C474 for ; Mon, 4 Feb 2008 11:29:28 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m14BRTTW059734 for ; Mon, 4 Feb 2008 11:27:29 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.2/8.14.1/Submit) id m14BRT3j059732; Mon, 4 Feb 2008 11:27:29 GMT (envelope-from nobody) Message-Id: <200802041127.m14BRT3j059732@www.freebsd.org> Date: Mon, 4 Feb 2008 11:27:29 GMT From: Jaakko Heinonen To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: bin/120249: [gzip] [patch] znew(1) is broken X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Feb 2008 11:30:01 -0000 >Number: 120249 >Category: bin >Synopsis: [gzip] [patch] znew(1) is broken >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Feb 04 11:30:01 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Jaakko Heinonen >Release: 7.0-RC1 >Organization: >Environment: >Description: 1) /usr/bin/znew script points to an interpreter (/bin/ksh) which doesn't exist in FreeBSD base. 2) The script uses a non-existent gzip command line option (-o). 3) After applying the patch provided below znew(1) -v switch still generates a different output compared to GNU znew. >How-To-Repeat: $ znew znew: not found $ head -1 /usr/bin/znew #!/bin/ksh - >Fix: Patch attached with submission follows: Index: znew =================================================================== RCS file: /home/ncvs/src/usr.bin/gzip/znew,v retrieving revision 1.1 diff -u -r1.1 znew --- znew 26 Jan 2007 10:19:07 -0000 1.1 +++ znew 3 Feb 2008 19:54:24 -0000 @@ -1,4 +1,4 @@ -#!/bin/ksh - +#!/bin/sh - # # $NetBSD: znew,v 1.2 2003/12/28 12:43:43 wiz Exp $ # $OpenBSD: znew,v 1.2 2003/08/05 18:22:17 deraadt Exp $ @@ -60,7 +60,7 @@ trap 'rm -f "$tmp"; exit 1' HUP INT QUIT PIPE TERM # Do the actual work, producing a file "$tmp" - if uncompress -f -c < "$filez" | gzip -f $gzipflags -o "$tmp"; then + if uncompress -f -c < "$filez" | gzip -cf $gzipflags > "$tmp"; then if test $kflag -eq 1 && smaller "$filez" "$tmp"; then echo -n "$prog: $filez is smaller than $filegz" @@ -120,7 +120,7 @@ esac done -shift OPTIND-1 +shift $(($OPTIND-1)) if test $# -eq 0; then echo "$usage" >Release-Note: >Audit-Trail: >Unformatted: