From owner-freebsd-current@FreeBSD.ORG  Wed Dec 31 07:05:56 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id DA44216A4CE
	for <freebsd-current@freebsd.org>;
	Wed, 31 Dec 2003 07:05:56 -0800 (PST)
Received: from ran.psg.com (ip166.usw253.dsl-acs2.sea.iinet.com
	[209.20.253.166])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B10C843D5C
	for <freebsd-current@freebsd.org>;
	Wed, 31 Dec 2003 07:05:54 -0800 (PST)	(envelope-from randy@psg.com)
Received: from localhost ([127.0.0.1] helo=ran.psg.com)
	by ran.psg.com with esmtp (Exim 4.24; FreeBSD)
	id 1Abhux-0003zx-Ss; Wed, 31 Dec 2003 07:05:51 -0800
From: Randy Bush <randy@psg.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Date: Wed, 31 Dec 2003 07:05:51 -0800
To: hm@kts.org (Hellmuth Michaelis)
References: <20031231082417.CCA7610@bert.int.kts.org>
Message-Id: <E1Abhux-0003zx-Ss@ran.psg.com>
cc: FreeBSD Current <freebsd-current@freebsd.org>
Subject: Re: More info: ATA hang on resume (fwd)
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 31 Dec 2003 15:05:57 -0000

sad to say, the appended patch did NOT fix the problem i
have with resume on a thinkpad t40p

randy

---

--- ata-all.c.orig	Mon Dec  1 20:24:13 2003
+++ ata-all.c	Thu Dec 25 00:00:44 2003
@@ -230,6 +230,7 @@
 int
 ata_reinit(struct ata_channel *ch)
 {
+    int i;
     struct ata_request *request = ch->running;
     int devices, misdev, newdev;
     
@@ -241,7 +242,11 @@
     ATA_FORCELOCK_CH(ch, ATA_CONTROL);
     ch->running = NULL;
     devices = ch->devices;
-    ch->hw.reset(ch);
+    for (i=0; i < 10; i++) {
+        ch->hw.reset(ch);
+        if (devices == ch->devices)
+            break;
+    }
     ATA_UNLOCK_CH(ch);
 
     /* detach what left the channel during reset */