From owner-svn-src-all@FreeBSD.ORG Tue Sep 22 20:58:18 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BF4AC1065670; Tue, 22 Sep 2009 20:58:18 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (chello087206049004.chello.pl [87.206.49.4]) by mx1.freebsd.org (Postfix) with ESMTP id 074838FC0A; Tue, 22 Sep 2009 20:58:17 +0000 (UTC) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id B949945E35; Tue, 22 Sep 2009 22:58:15 +0200 (CEST) Received: from localhost (chello087206049004.chello.pl [87.206.49.4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id EA95145C98; Tue, 22 Sep 2009 22:58:09 +0200 (CEST) Date: Tue, 22 Sep 2009 22:58:10 +0200 From: Pawel Jakub Dawidek To: John Baldwin Message-ID: <20090922205809.GB2970@garage.freebsd.pl> References: <200909221622.n8MGM5WK025136@svn.freebsd.org> <200909221301.07781.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ew6BAiZeqk4r7MaW" Content-Disposition: inline In-Reply-To: <200909221301.07781.jhb@freebsd.org> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 8.0-CURRENT i386 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.6 required=4.5 tests=BAYES_00,RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: svn-src-head@freebsd.org, Roman Divacky , src-committers@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r197408 - in head/sys: conf ufs/ufs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Sep 2009 20:58:18 -0000 --ew6BAiZeqk4r7MaW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 22, 2009 at 01:01:07PM -0400, John Baldwin wrote: > On Tuesday 22 September 2009 12:22:05 pm Roman Divacky wrote: > > Author: rdivacky > > Date: Tue Sep 22 16:22:05 2009 > > New Revision: 197408 > > URL: http://svn.freebsd.org/changeset/base/197408 > >=20 > > Log: > > Don't build ufs_gjournal.c at all if UFS_GJOURNAL option is not given > > instead of building an almost empty C file. > > =20 > > Approved by: pjd > > Approved by: ed (mentor, implicit) > >=20 > > Modified: > > head/sys/conf/files > > head/sys/ufs/ufs/ufs_gjournal.c > >=20 > > Modified: head/sys/conf/files > >=20 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > > --- head/sys/conf/files Tue Sep 22 16:16:02 2009 (r197407) > > +++ head/sys/conf/files Tue Sep 22 16:22:05 2009 (r197408) > > @@ -2634,7 +2634,7 @@ ufs/ufs/ufs_acl.c optional ffs > > ufs/ufs/ufs_bmap.c optional ffs > > ufs/ufs/ufs_dirhash.c optional ffs > > ufs/ufs/ufs_extattr.c optional ffs > > -ufs/ufs/ufs_gjournal.c optional ffs > > +ufs/ufs/ufs_gjournal.c optional ffs UFS_GJOURNAL > > ufs/ufs/ufs_inode.c optional ffs > > ufs/ufs/ufs_lookup.c optional ffs > > ufs/ufs/ufs_quota.c optional ffs >=20 > Hmm, shouldn't this be lowercase? That was my comment to the patch... --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --ew6BAiZeqk4r7MaW Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFKuTphForvXbEpPzQRAiJxAKDMRl5apNxxJYB0g2fe7kBH9wwDsQCfb+GD BOkLsNIjGBGIfA3DurVAYH4= =tG3f -----END PGP SIGNATURE----- --ew6BAiZeqk4r7MaW--