From owner-freebsd-bugs@FreeBSD.ORG  Sat May  7 15:50:07 2005
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9426516A4DB
	for <freebsd-bugs@hub.freebsd.org>;
	Sat,  7 May 2005 15:50:07 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 788CE43DB5
	for <freebsd-bugs@hub.freebsd.org>;
	Sat,  7 May 2005 15:50:07 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j47Fo7m5016221
	for <freebsd-bugs@freefall.freebsd.org>; Sat, 7 May 2005 15:50:07 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j47Fo7Mg016220;
	Sat, 7 May 2005 15:50:07 GMT
	(envelope-from gnats)
Date: Sat, 7 May 2005 15:50:07 GMT
Message-Id: <200505071550.j47Fo7Mg016220@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Rostislav Krasny <rosti.bsd@gmail.com>
Subject: Re: bin/80732: [PATCH]: getty(8) and telnetd(8) ignore the 'if'
	option of gettytab(5) and don't print initial message from a file
	(by default /etc/issue) before the login prompt
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Rostislav Krasny <rosti.bsd@gmail.com>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 07 May 2005 15:50:07 -0000

The following reply was made to PR bin/80732; it has been noted by GNATS.

From: Rostislav Krasny <rosti.bsd@gmail.com>
To: Maxim Konovalov <maxim@macomnet.ru>
Cc: bug-followup@freebsd.org
Subject: Re: bin/80732: [PATCH]: getty(8) and telnetd(8) ignore the 'if' option of gettytab(5) and don't print initial message from a file (by default /etc/issue) before the login prompt
Date: Sat, 7 May 2005 17:41:58 +0200

 On 5/7/05, Maxim Konovalov <maxim@macomnet.ru> wrote:
 > Does your patch correlate with bin/23562?
 >=20
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dbin/23562
 
 The bin/23562 is about same bugs of getty(8) and telnetd(8). It have
 very old patch for telnetd(8) and no patch for getty(8).
 
 The history of the patch in bin/23562 is mysterious. Originally it was
 introduced in bin/6492 and then commited, many years ago:
 http://www.freebsd.org/cgi/cvsweb.cgi/src/libexec/telnetd/Attic/telnetd.c.d=
 iff?r1=3D1.7.2.4&r2=3D1.7.2.5
 Three years later (August 2001) it was removed during: "Feature
 merging and diff reduction between this code and crypto telnet":
 http://www.freebsd.org/cgi/cvsweb.cgi/src/libexec/telnetd/Attic/telnetd.c.d=
 iff?r1=3D1.29&r2=3D1.30
 But the removing was not complete. telnetd.c still includes
 <sys/mman.h> that had been need for mmap() and munmap() and manual
 page of telnetd(8) still states that 'if' option of gettytab is
 supported. The patch in bin/23562 was proposed in February 2001, i.e.
 before it was removed in revision 1.30.
 In July 2003 the sources of telnetd(8) were moved to
 src/contrib/telnet where the revision numbering is different.
 
 Personally I think my patch ot telnetd.c is better and the the
 inclusion of <sys/mman.h> could be also removed from the telnetd.c as
 needless.