From owner-freebsd-apache@FreeBSD.ORG Fri Jan 7 19:31:28 2011 Return-Path: Delivered-To: apache@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 15DAC106564A; Fri, 7 Jan 2011 19:31:28 +0000 (UTC) (envelope-from ohauer@FreeBSD.org) Received: from u18-124.dslaccess.de (unknown [194.231.39.124]) by mx1.freebsd.org (Postfix) with ESMTP id B1C038FC14; Fri, 7 Jan 2011 19:31:27 +0000 (UTC) Received: from [172.20.1.100] (unknown [172.20.1.100]) by u18-124.dslaccess.de (Postfix) with ESMTPSA id 28BE8205E0; Fri, 7 Jan 2011 20:31:22 +0100 (CET) Message-ID: <4D276AF6.5090804@FreeBSD.org> Date: Fri, 07 Jan 2011 20:35:18 +0100 From: Olli Hauer User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.13) Gecko/20101207 Thunderbird/3.1.7 MIME-Version: 1.0 To: "Philip M. Gollucci" References: <4D243209.5040703@FreeBSD.org> <4D24BED1.7070004@p6m7g8.com> <4D265CF2.5090208@FreeBSD.org> <4D26B3C6.4050804@p6m7g8.com> <4D272510.9030908@FreeBSD.org> <4D275E83.2000204@p6m7g8.com> In-Reply-To: <4D275E83.2000204@p6m7g8.com> X-Enigmail-Version: 1.1.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: ohauer@FreeBSD.org, "Philip M. Gollucci" , apache@FreeBSD.org Subject: Re: question about PR: ports/147009: Mk/bsd.apache.mk: [patch] default to www/apache22 X-BeenThere: freebsd-apache@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: ohauer@FreeBSD.org List-Id: Support of apache-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Jan 2011 19:31:28 -0000 On 2011-01-07 19:42, Philip M. Gollucci wrote: > On 01/07/11 14:37, Olli Hauer wrote: >> However I'm a friend of more explicit test, so I like this more. >> >> .elif ${USE_APACHE:C/\.//:C/\+//:C/13//:C/20//:C/22//:C/24//} == "" >> or >> .elif ${USE_APACHE:C/\.//:C/\+//:S/^13//:S/^20//:S/^22//:S/^24//} == "" > Seems logical. > >> The following lines in bsd.apache.mk should be reviewed, for example >> APACHE_SUPPORTED_VERSION is nowhere used in ports/MK/* > This is used in some ports though I'm not sure I'm a fan of it. > >> ================================================ >> USE_APACHE= 1.3 / 13 => APACHE_VERSION=13, make: error version ... > this shouldn't fail, it should use 13 > >> USE_APACHE= 1.3+/13+ => APACHE_VERSION=22, make: OK >> >> USE_APACHE= 2.0 / 20 => APACHE_VERSION=20, make: error version ... > ditto above, should use 20 > >> USE_APACHE= 2.0+/20+ => APACHE_VERSION=22, make: OK >> >> USE_APACHE= 2.2 / 22 => APACHE_VERSION=22, make: OK >> USE_APACHE= 2.2+/ 22+ => APACHE_VERSION=22, make: OK >> >> USE_APACHE= 2.4 / 24 => APACHE_VERSION=24, make: error version ... >> USE_APACHE= 2.4+/ 24+ => APACHE_VERSION=24, make: error version ... > both of these should use 24 > > bsd.perl.mk / bsd.python.mk might be helpful for the 'range' or -+ logic > though I'm not sure its compatible. No, I think the fail is valid, since this was the second test case, where I defined *"APACHE_PORT= www/apache22"* in /etc/make.conf! You stripped the following column header for this tests > Additional results with "APACHE_PORT= www/apache22" > in /etc/make.conf and fire `make' command. Without /etc/make.conf (first test case) all tests are success. I uploaded the last diff against bsd.apache.mk http://people.freebsd.org/~ohauer/diffs/PR_147009_ports__Mk__bsd.apache.mk.diff