From owner-p4-projects@FreeBSD.ORG  Thu May 27 10:49:40 2010
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 8A8721065670; Thu, 27 May 2010 10:49:40 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4EB96106566B
	for <perforce@FreeBSD.org>; Thu, 27 May 2010 10:49:40 +0000 (UTC)
	(envelope-from gcooper@FreeBSD.org)
Received: from repoman.freebsd.org (unknown [IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 3C4B48FC12
	for <perforce@FreeBSD.org>; Thu, 27 May 2010 10:49:40 +0000 (UTC)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id o4RAne5X026877
	for <perforce@FreeBSD.org>; Thu, 27 May 2010 10:49:40 GMT
	(envelope-from gcooper@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id o4RAneFp026875
	for perforce@freebsd.org; Thu, 27 May 2010 10:49:40 GMT
	(envelope-from gcooper@FreeBSD.org)
Date: Thu, 27 May 2010 10:49:40 GMT
Message-Id: <201005271049.o4RAneFp026875@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	gcooper@FreeBSD.org using -f
From: Garrett Cooper <gcooper@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Precedence: bulk
Cc: 
Subject: PERFORCE change 178872 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 27 May 2010 10:49:40 -0000

http://p4web.freebsd.org/@@178872?ac=10

Change 178872 by gcooper@gcooper-bayonetta on 2010/05/27 10:49:22

	Fix some bass ackwards return code checks (== 0 vs != NULL).

Affected files ...

.. //depot/projects/soc2007/gcooper-pkg_install-enhancements-simplified/lib/libpkg/pen.c#5 edit

Differences ...

==== //depot/projects/soc2007/gcooper-pkg_install-enhancements-simplified/lib/libpkg/pen.c#5 (text+ko) ====

@@ -105,13 +105,13 @@
 	char cwd[FILENAME_MAX];
 	const char *pen_location = NULL;
 
-	if (find_play_pen(pen, sz) != NULL && mkdtemp(pen) == 0) {
+	if (find_play_pen(pen, sz) != NULL && mkdtemp(pen) != NULL) {
 
 		if (min_free(pen) < sz) {
 			rmdir(pen);
 			errno = ENOSPC;
 		}
-		else if (getcwd(cwd, FILENAME_MAX) == 0 && chdir(pen) == 0) {
+		else if (getcwd(cwd, FILENAME_MAX) != NULL && chdir(pen) == 0) {
 			strcpy(PenLocation, pen);
 			pen_location = pushPen(cwd);
 		}