From owner-freebsd-hackers@FreeBSD.ORG  Mon Jun 25 19:20:01 2007
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
X-Original-To: freebsd-hackers@freebsd.org
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id D835716A46E
	for <freebsd-hackers@freebsd.org>; Mon, 25 Jun 2007 19:20:01 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from outF.internet-mail-service.net (outF.internet-mail-service.net
	[216.240.47.229])
	by mx1.freebsd.org (Postfix) with ESMTP id BF83013C46C
	for <freebsd-hackers@freebsd.org>; Mon, 25 Jun 2007 19:20:01 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from mx0.idiom.com (HELO idiom.com) (216.240.32.160)
	by out.internet-mail-service.net (qpsmtpd/0.32) with ESMTP;
	Mon, 25 Jun 2007 12:20:01 -0700
Received: from julian-mac.elischer.org (nat.ironport.com [63.251.108.100])
	by idiom.com (Postfix) with ESMTP id F25EA125A23;
	Mon, 25 Jun 2007 12:20:00 -0700 (PDT)
Message-ID: <46801566.2080706@elischer.org>
Date: Mon, 25 Jun 2007 12:20:06 -0700
From: Julian Elischer <julian@elischer.org>
User-Agent: Thunderbird 2.0.0.4 (Macintosh/20070604)
MIME-Version: 1.0
To: Danny Braniss <danny@cs.huji.ac.il>
References: <E1I2nbz-000Nqm-Sv@cs1.cs.huji.ac.il>
	<467FF435.6050108@elischer.org>
	<E1I2tym-000DGS-50@cs1.cs.huji.ac.il>
In-Reply-To: <E1I2tym-000DGS-50@cs1.cs.huji.ac.il>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-hackers@freebsd.org, freebsd-current@FreeBSD.ORG
Subject: Re: KSE was Re: open/close/ioctl api change?
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Jun 2007 19:20:02 -0000

Danny Braniss wrote:
>> Danny Braniss wrote:
>>>> actually it's the struct thread *tp where my problems are,
>>>> this code works fine under 6.2, and did work till some days ago under current.
>>>>
>>>> static int
>>>> iscsi_open(struct cdev *dev, int flags, int otype, struct thread *td)
>>>> {
>>>> ...
>>>> 	debug(3, "td->td_proc=%p", td->td_proc);
>>>> 	debug(3, "td->td_proc->p_pid=%d pid=%d",
>>>> 	   td->td_proc->p_pid, curproc->p_pid);
>>>> ...
>>>>
>>>> the first debug prints out td->td_proc=0 and the next one panics.
>>> found the problem, 'option KSE' which is defined now in DEFAULTS,
>>> and i'm compiling a module! which does not include DEFAULTS!
>>>
>> even so it shouldnt' happen..
>>
> why? I'm compiling outside the source tree.
> I agree that it shouldn't, specially, since it took me a long
> time to find the problem :-), but I can't see how config options
> can be exported. Unless, the make file is made aware of the KERNCONF file.

there should be no place in the source at any time where a thread 
that is not on the free list could have a td_proc of NULL.
it doesn't matter about where a module came from etc.. the fact that
it happened is a bug somewhere.

> 
> 	danny
>