From owner-freebsd-ports@FreeBSD.ORG Sat Feb 16 06:46:52 2013 Return-Path: Delivered-To: freebsd-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 7AC47B30 for ; Sat, 16 Feb 2013 06:46:52 +0000 (UTC) (envelope-from mi+thun@aldan.algebra.com) Received: from smtp.rcn.com (smtp.rcn.com [69.168.97.78]) by mx1.freebsd.org (Postfix) with ESMTP id 3A005CE5 for ; Sat, 16 Feb 2013 06:46:52 +0000 (UTC) X_CMAE_Category: 0,0 Undefined,Undefined X-CNFS-Analysis: v=2.0 cv=YKIdOG6x c=1 sm=0 a=qeRvV3Pq7Nxew94SikMvAA==:17 a=d8Isu0L9vBEA:10 a=LbyY71X0eGoA:10 a=YNqtyO0l_hcA:10 a=LaogzpLLAAAA:8 a=FoeWSrC19yYA:10 a=3z5rlSg_Pv_1HymSMvUA:9 a=wPNLvfGTeEIA:10 a=clQtRDmiUXPLPEhDsuYA:9 a=_W_S_7VecoQA:10 a=1h1U7Ec8lvngekNf:21 a=qeRvV3Pq7Nxew94SikMvAA==:117 X-CM-Score: 0 X-Scanned-by: Cloudmark Authority Engine Authentication-Results: smtp01.rcn.cmh.synacor.com header.from=mi+thun@aldan.algebra.com; sender-id=neutral Authentication-Results: smtp01.rcn.cmh.synacor.com smtp.mail=mi+thun@aldan.algebra.com; spf=neutral; sender-id=neutral Authentication-Results: smtp01.rcn.cmh.synacor.com smtp.user=anat; auth=pass (PLAIN) Received-SPF: neutral (smtp01.rcn.cmh.synacor.com: 71.187.31.131 is neither permitted nor denied by domain of aldan.algebra.com) Received: from [71.187.31.131] ([71.187.31.131:65249] helo=[192.168.1.8]) by smtp.rcn.com (envelope-from ) (ecelerity 2.2.3.49 r(42060/42061)) with ESMTPA id C2/65-28101-95B2F115; Sat, 16 Feb 2013 01:46:49 -0500 Message-ID: <511F2B57.8070109@aldan.algebra.com> Date: Sat, 16 Feb 2013 01:46:47 -0500 From: "Mikhail T." User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130209 Thunderbird/17.0.2 MIME-Version: 1.0 To: Ian Lepore Subject: Re: ports include /etc/src.conf? i.e. graphics/libfpx References: <511B662C.7030602@zedat.fu-berlin.de> <511B874A.7080901@kbh.biglobe.ne.jp> <511BBDAD.1080806@zedat.fu-berlin.de> <511CD83C.107@aldan.algebra.com> <511CE2AD.8050506@aldan.algebra.com> <20130214143445.GA5414@straylight.m.ringlet.net> <511EB799.8090401@aldan.algebra.com> <1360973567.1164.13.camel@revolution.hippie.lan> <511F068C.8060503@aldan.algebra.com> <1360988497.1164.21.camel@revolution.hippie.lan> In-Reply-To: <1360988497.1164.21.camel@revolution.hippie.lan> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: Tom Evans , Yamaya Takashi , Kimmo Paasiala , jmg@funkthat.com, Current FreeBSD , Ports FreeBSD , "O. Hartmann" X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Feb 2013 06:46:52 -0000 15.02.2013 23:21, Ian Lepore ???????(??): > Since /home/ian/foo/BSDmakefile is not building something that is part > of the freebsd world, or the freebsd kernel, then according to that > paragraph, a build using that makefile should not be affected > by /etc/src.conf. Maybe it should not be affected. But it is. And the only way to avoid it is by using an undocumented knob. If the documentation properly documents the feature, then the implementation of it is faulty. As suggested earlier, perhaps, the file should only be included, if something special is put into environment (by /usr/src/Makefile). Instead it bsd.own.mk currently sucks-in /etc/src.conf by default -- and one has to set an undocumented flag to avoid that. Something like this (untested): Index: Makefile =================================================================== --- Makefile (revision 246385) +++ Makefile (working copy) @@ -293,7 +293,7 @@ # the system bsdmake-like utility to be overridden. # MMAKEENV= MAKEOBJDIRPREFIX=${MAKEPATH} \ - DESTDIR= \ + DESTDIR= _WITH_SRCCONF= \ INSTALL="sh ${.CURDIR}/tools/install.sh" MMAKE= ${MMAKEENV} ${MAKE} \ -D_UPGRADING \ Index: share/mk/bsd.own.mk =================================================================== --- share/mk/bsd.own.mk (revision 246385) +++ share/mk/bsd.own.mk (working copy) @@ -115,7 +115,7 @@ .if !target(____) ____: -.if !defined(_WITHOUT_SRCCONF) +.if defined(_WITH_SRCCONF) SRCCONF?= /etc/src.conf .if exists(${SRCCONF}) .include "${SRCCONF}" Yours, -mi