From owner-cvs-all Thu Dec 3 19:47:11 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id TAA13292 for cvs-all-outgoing; Thu, 3 Dec 1998 19:47:11 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from apollo.backplane.com (apollo.backplane.com [209.157.86.2]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id TAA13287; Thu, 3 Dec 1998 19:47:08 -0800 (PST) (envelope-from dillon@apollo.backplane.com) Received: (from dillon@localhost) by apollo.backplane.com (8.9.1/8.9.1) id TAA02228; Thu, 3 Dec 1998 19:46:51 -0800 (PST) (envelope-from dillon) Date: Thu, 3 Dec 1998 19:46:51 -0800 (PST) From: Matthew Dillon Message-Id: <199812040346.TAA02228@apollo.backplane.com> To: "Andrey A. Chernov" Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/netinet icmp_var.h ip_icmp.c tcp_input.c udp_usrreq.c References: <199812032023.MAA02215@freefall.freebsd.org> <19981204064311.A31118@nagual.pp.ru> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk :On Thu, Dec 03, 1998 at 12:23:21PM -0800, Matt Dillon wrote: :> dillon 1998/12/03 12:23:21 PST :> :> Modified files: :> sys/netinet icmp_var.h ip_icmp.c tcp_input.c :> udp_usrreq.c : :Please remove or #ifdef KERNEL :#include "opt_icmp_bandlim.h" :from icmp_var.h, this file sometimes used in userland applications which :are broken now. :Function badport_badlim should also be removed of KERNEL #ifdefed. : :Basically I dislike idea of touching icmp_var.h at all, could you add :separate include file for this stuff, please? I'll add the #ifdef KERNEL. I'd gladly move everything out of icmp_var.h if you tell me how to deal with the sysctl initialization (can I just use the AUTO mode and get rid of the ICMPCTL_MAXID and ICMP_BANDLI<_INFO junk?) and where to put the badport_bandlim() extern. -Matt :-- :Andrey A. Chernov :http://www.nagual.pp.ru/~ache/ :MTH/SH/HE S-- W-- N+ PEC>+ D A a++ C G>+ QH+(++) 666+>++ Y : : Matthew Dillon Engineering, HiWay Technologies, Inc. & BEST Internet Communications & God knows what else. (Please include original email in any response) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message