From owner-freebsd-current@FreeBSD.ORG  Wed Dec 15 21:54:23 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 8F81916A4CE; Wed, 15 Dec 2004 21:54:23 +0000 (GMT)
Received: from flash.atmos.colostate.edu (flash.atmos.colostate.edu
	[129.82.48.50])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 4413543D46; Wed, 15 Dec 2004 21:54:23 +0000 (GMT)
	(envelope-from tarcieri@flash.atmos.colostate.edu)
Received: from flash.atmos.colostate.edu (localhost [127.0.0.1])
	iBFLsMps019400;	Wed, 15 Dec 2004 14:54:22 -0700 (MST)
	(envelope-from tarcieri@flash.atmos.colostate.edu)
Received: (from tarcieri@localhost)
	by flash.atmos.colostate.edu (8.13.1/8.13.1/Submit) id iBFLsME9019399;
	Wed, 15 Dec 2004 14:54:22 -0700 (MST)
	(envelope-from tarcieri)
Date: Wed, 15 Dec 2004 14:54:22 -0700
From: Tony Arcieri <tarcieri@atmos.colostate.edu>
To: David Schultz <das@FreeBSD.ORG>
Message-ID: <20041215215422.GA19373@flash.atmos.colostate.edu>
References: <20041214222444.GA9668@flash.atmos.colostate.edu>
	<3308.192.168.1.9.1103065723.squirrel@192.168.1.9>
	<20041215001222.GB9957@flash.atmos.colostate.edu>
	<41BF9130.9070907@freebsd.org> <20041215152931.H60504@mail.chesapeake.net>
	<20041215210119.GF17276@flash.atmos.colostate.edu>
	<20041215214050.GA64783@VARK.MIT.EDU>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20041215214050.GA64783@VARK.MIT.EDU>
User-Agent: Mutt/1.4.2.1i
cc: freebsd-current@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/kern sched_ule.c (fwd)
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Dec 2004 21:54:23 -0000

On Wed, Dec 15, 2004 at 04:40:50PM -0500, David Schultz wrote:
> On Wed, Dec 15, 2004, Tony Arcieri wrote:
> > And am I correct that the UMA implementation in RELENG_5 has rendered
> > proc_fini() obsolete and thus it won't ever be called?
> 
> This has very little to do with either UMA or ULE.  Yes, it's
> unused, but it's still there as a reminder that it *ought* to be
> used.  Unless there are still races I don't know about, it's
> probably safe to start using it again.

Well, I'm going by the comments and implementation from kern_proc.c in HEAD:

/*
 * UMA should ensure that this function is never called.
 * Freeing a proc structure would violate type stability.
 */
static void
proc_fini(void *mem, int size)
{
	
	panic("proc reclaimed");
}

The implementation in RELENG_5 invokes a scheduler function which is no
longer present in HEAD.

Tony Arcieri