From owner-cvs-all@FreeBSD.ORG Mon Oct 31 22:03:39 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A480116A41F; Mon, 31 Oct 2005 22:03:39 +0000 (GMT) (envelope-from fenner@research.att.com) Received: from mail-yellow.research.att.com (mail-dark.research.att.com [192.20.225.112]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1522143D46; Mon, 31 Oct 2005 22:03:39 +0000 (GMT) (envelope-from fenner@research.att.com) Received: from bright.research.att.com (bright.research.att.com [135.207.20.189]) by mail-blue.research.att.com (Postfix) with ESMTP id 9040A147BD9; Mon, 31 Oct 2005 17:03:38 -0500 (EST) Received: (from fenner@localhost) by bright.research.att.com (8.12.11/8.12.10/Submit) id j9VM3c3E020714; Mon, 31 Oct 2005 14:03:38 -0800 From: Bill Fenner Message-Id: <200510312203.j9VM3c3E020714@bright.research.att.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII To: Colin Percival References: <200510280258.j9S2wpmL058704@repoman.freebsd.org> <20051030194833.GA2699@heff.fud.org.nz> <20051030224106.GC891@zaphod.nitro.dk> <200510310139.j9V1dZ3i025712@bright.research.att.com> <436585A4.6020008@freebsd.org> Date: Mon, 31 Oct 2005 14:03:38 -0800 Versions: dmail (linux) 2.7/makemail 2.14 Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Xin LI , "Simon L. Nielsen" , Andrew Thompson Subject: Re: cvs commit: src UPDATING X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Oct 2005 22:03:39 -0000 I've turned off ending cvs logs at the end-of-file string (77 ='s) on http://people.freebsd.org/~fenner/newcgi/cvsweb.cgi . The URL that started this thread, http://people.freebsd.org/~fenner/newcgi/cvsweb.cgi/src/UPDATING?only_with_tag=RELENG_6 seems to work ok. You can see the oddities that cvsweb experiences because of the contents of the log. See, for example, UPDATING without the only_with_tag=, look at rev 1.342.2.12. cvsweb thinks the log message for that rev is just MFC: RCS file: /home/ncvs/src/UPDATING,v because the next line is the line in the log entry is the line that seperates log entries. Now, look down to 1.370, which was the rev that is actually described in the MFC log in 1.342.2.12 - not only is it duplicated in the list (the revisions on the page go 1.371, 1.370, 1.370, 1.369), the actual message is duplicated. It gets worse than this, actually - a good example of worse-ness is http://people.freebsd.org/~fenner/newcgi/cvsweb.cgi/src/etc/rc.d/localpkg localpkg itself doesn't actually have a rev 1.335 in between its 1.5 and 1.6; in addition, its rev 1.4 isn't actually dated earlier than its 1.3 - those are all false revisions generated by log messages in log messages. (If you believed the cvsweb output, you might start running around shouting "repo corruption!"...) I doubt that we'd end up being comfortable with the amount of repo surgery that's probably needed to correct all instances of this problem, and it's just too darn handy to paste "cvs log" output into MFC commit messages so the problem isn't going to go away. Bill