From owner-cvs-all@FreeBSD.ORG  Thu Nov 15 18:14:56 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D8A8016A418;
	Thu, 15 Nov 2007 18:14:56 +0000 (UTC)
	(envelope-from sgk@troutmask.apl.washington.edu)
Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu
	[128.208.78.105])
	by mx1.freebsd.org (Postfix) with ESMTP id 9A94613C43E;
	Thu, 15 Nov 2007 18:14:55 +0000 (UTC)
	(envelope-from sgk@troutmask.apl.washington.edu)
Received: from troutmask.apl.washington.edu (localhost.apl.washington.edu
	[127.0.0.1])
	by troutmask.apl.washington.edu (8.14.1/8.14.1) with ESMTP id
	lAFIE1UM017145; Thu, 15 Nov 2007 10:14:01 -0800 (PST)
	(envelope-from sgk@troutmask.apl.washington.edu)
Received: (from sgk@localhost)
	by troutmask.apl.washington.edu (8.14.1/8.14.1/Submit) id
	lAFIE1nx017144; Thu, 15 Nov 2007 10:14:01 -0800 (PST)
	(envelope-from sgk)
Date: Thu, 15 Nov 2007 10:14:01 -0800
From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: Julian Elischer <julian@elischer.org>
Message-ID: <20071115181401.GA17094@troutmask.apl.washington.edu>
References: <200711151416.lAFEGKJ6059040@repoman.freebsd.org>
	<473C865D.8070809@elischer.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <473C865D.8070809@elischer.org>
User-Agent: Mutt/1.4.2.3i
Cc: cvs-src@freebsd.org, Gleb Smirnoff <glebius@freebsd.org>,
	src-committers@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/kern kern_kse.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Nov 2007 18:14:57 -0000

On Thu, Nov 15, 2007 at 09:48:13AM -0800, Julian Elischer wrote:
> Gleb Smirnoff wrote:
> >glebius     2007-11-15 14:16:20 UTC
> >
> >  FreeBSD src repository
> >
> >  Modified files:
> >    sys/kern             kern_kse.c 
> >  Log:
> >  Fix build.
> 
> thanks.. I need to remember to stop applying patches 
> from build tree to checkin tree by hand.
> 
> the trouble is I can't commit from my current test machine (no 
> internet access) so after testing, I make a patch and move to 
> to my commit machine, where I can commit it, but
> when it's a small patch, one is always tempted to 
> do it by hand and then ...
> 
> Julian, repeat after me..
> 
> "no matter how small the change, use diff + patch to move it across."

After applying the patch on your commit machine, is it too
difficult to actually retest before committing?  This would
catch the broken commit before it becomes a Tinderbox issue.

Seems to be a QA problem on your part.

-- 
Steve