From owner-cvs-all Thu Dec 3 20:03:03 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id UAA14775 for cvs-all-outgoing; Thu, 3 Dec 1998 20:03:03 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from nagual.pp.ru (lsd.relcom.eu.net [193.125.27.73]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id UAA14754; Thu, 3 Dec 1998 20:02:57 -0800 (PST) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.9.1/8.9.1) id HAA39578; Fri, 4 Dec 1998 07:02:38 +0300 (MSK) (envelope-from ache) Message-ID: <19981204070237.A38284@nagual.pp.ru> Date: Fri, 4 Dec 1998 07:02:37 +0300 From: "Andrey A. Chernov" To: Matthew Dillon Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/netinet icmp_var.h ip_icmp.c tcp_input.c udp_usrreq.c Mail-Followup-To: Matthew Dillon , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <199812032023.MAA02215@freefall.freebsd.org> <19981204064311.A31118@nagual.pp.ru> <199812040346.TAA02228@apollo.backplane.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.93.2i In-Reply-To: <199812040346.TAA02228@apollo.backplane.com>; from dillon@apollo.backplane.com on Thu, Dec 03, 1998 at 07:46:51PM -0800 Organization: Biomechanoid Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Thu, Dec 03, 1998 at 07:46:51PM -0800, Matthew Dillon wrote: > I'll add the #ifdef KERNEL. I'd gladly move everything out of > icmp_var.h if you tell me how to deal with the sysctl initialization > (can I just use the AUTO mode and get rid of the ICMPCTL_MAXID and > ICMP_BANDLI<_INFO junk?) and where to put the badport_bandlim() extern. Well, lets sysctl stuff stays here, but it must be _not_optional_ to allow applications use it independently of kernel options. Look like netstat use ICMP sysctls. I.e. you need _always_ enable BANDLIM sysctl from outside, but return error, if it is not configured inside kernel. -- Andrey A. Chernov http://www.nagual.pp.ru/~ache/ MTH/SH/HE S-- W-- N+ PEC>+ D A a++ C G>+ QH+(++) 666+>++ Y To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message