From owner-cvs-all@FreeBSD.ORG Thu Nov 15 18:29:56 2007 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 099A216A418 for ; Thu, 15 Nov 2007 18:29:56 +0000 (UTC) (envelope-from julian@elischer.org) Received: from outF.internet-mail-service.net (outF.internet-mail-service.net [216.240.47.229]) by mx1.freebsd.org (Postfix) with ESMTP id DF11713C43E for ; Thu, 15 Nov 2007 18:29:55 +0000 (UTC) (envelope-from julian@elischer.org) Received: from mx0.idiom.com (HELO idiom.com) (216.240.32.160) by out.internet-mail-service.net (qpsmtpd/0.40) with ESMTP; Thu, 15 Nov 2007 10:29:52 -0800 X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e Received: from julian-mac.elischer.org (home.elischer.org [216.240.48.38]) by idiom.com (Postfix) with ESMTP id 8D438126A2D; Thu, 15 Nov 2007 10:29:51 -0800 (PST) Message-ID: <473C901F.1080906@elischer.org> Date: Thu, 15 Nov 2007 10:29:51 -0800 From: Julian Elischer User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070728) MIME-Version: 1.0 To: Steve Kargl References: <200711151416.lAFEGKJ6059040@repoman.freebsd.org> <473C865D.8070809@elischer.org> <20071115181401.GA17094@troutmask.apl.washington.edu> In-Reply-To: <20071115181401.GA17094@troutmask.apl.washington.edu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, Gleb Smirnoff , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_kse.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Nov 2007 18:29:56 -0000 Steve Kargl wrote: > On Thu, Nov 15, 2007 at 09:48:13AM -0800, Julian Elischer wrote: >> Gleb Smirnoff wrote: >>> glebius 2007-11-15 14:16:20 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/kern kern_kse.c >>> Log: >>> Fix build. >> thanks.. I need to remember to stop applying patches >> from build tree to checkin tree by hand. >> >> the trouble is I can't commit from my current test machine (no >> internet access) so after testing, I make a patch and move to >> to my commit machine, where I can commit it, but >> when it's a small patch, one is always tempted to >> do it by hand and then ... >> >> Julian, repeat after me.. >> >> "no matter how small the change, use diff + patch to move it across." > > After applying the patch on your commit machine, is it too > difficult to actually retest before committing? This would > catch the broken commit before it becomes a Tinderbox issue. > > Seems to be a QA problem on your part. yes.. but I can't do a compile from my mac. (my commit machine). The answer is to be rigorous about how I move the patch from the build machine to the commit machine. This is a temporary situation. new infrastructure will let me commit from my build machine again. >