From owner-svn-src-all@FreeBSD.ORG Tue May 22 05:46:53 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 17F9A106567B; Tue, 22 May 2012 05:46:53 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id BEC258FC17; Tue, 22 May 2012 05:46:52 +0000 (UTC) Received: by pbbro2 with SMTP id ro2so8512314pbb.13 for ; Mon, 21 May 2012 22:46:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:mime-version:content-type:from:in-reply-to:date:cc :message-id:references:to:x-mailer; bh=vRsnF2p1Brd0wY5hp7E02TYITj1r+90rT9bSmOsVbJQ=; b=Mvc60MWui0qEI8I/5sC+Wlhgq+ihcwwGbQITtAFN0zT2Y1fjC0U4Ot18ZQR/6msUBN dB8lOXao/hctxfyfBb0sNmdmYuHVQzD+cFBkZsRqoR/Ny91mHDL6ItfOPSzsbiZYV6KH 3bGPpk9g/6nGBSZaABvWQy8QzGC+MFgh3LFvSz7NnMtuAE2WZfMMzhN6a+10Irs5Mh5R htKSGmxMZFAVopmx7k2RBTRe1Tf0AxUP8eG2YWKFIRKf6aKc6lBTLewE4nvyyce1WJpl RqLMWPUG0KXCdaHiyRqO82R/+O5V9jp7AUf6vbnZ+1Bx7n9CI5Hi3la81darVBhinIhK WIcw== Received: by 10.68.222.197 with SMTP id qo5mr7859140pbc.72.1337665612301; Mon, 21 May 2012 22:46:52 -0700 (PDT) Received: from [192.168.20.11] (c-24-19-191-56.hsd1.wa.comcast.net. [24.19.191.56]) by mx.google.com with ESMTPS id ob8sm12070644pbb.17.2012.05.21.22.46.50 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 21 May 2012 22:46:51 -0700 (PDT) Mime-Version: 1.0 (Apple Message framework v1257) From: Garrett Cooper In-Reply-To: <20120522054113.GL63744@ithaqua.etoilebsd.net> Date: Mon, 21 May 2012 22:46:50 -0700 Message-Id: References: <201205220301.q4M31tJn084097@svn.freebsd.org> <20120522054113.GL63744@ithaqua.etoilebsd.net> To: Baptiste Daroussin X-Mailer: Apple Mail (2.1257) Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Kevin Lo , svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Baptiste Daroussin Subject: Re: svn commit: r235771 - head/bin/expr X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2012 05:46:53 -0000 On May 21, 2012, at 10:41 PM, Baptiste Daroussin wrote: > On Mon, May 21, 2012 at 09:20:59PM -0700, Garrett Cooper wrote: >> On Mon, May 21, 2012 at 8:01 PM, Kevin Lo wrote: >>> Author: kevlo >>> Date: Tue May 22 03:01:54 2012 >>> New Revision: 235771 >>> URL: http://svn.freebsd.org/changeset/base/235771 >>>=20 >>> Log: >>> Remove redundant declaration of yyparse >>>=20 >>> Reported by: tinderbox >>>=20 >>> Modified: >>> head/bin/expr/expr.y >>>=20 >>> Modified: head/bin/expr/expr.y >>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>> --- head/bin/expr/expr.y Tue May 22 02:37:04 2012 = (r235770) >>> +++ head/bin/expr/expr.y Tue May 22 03:01:54 2012 = (r235771) >>> @@ -74,7 +74,6 @@ int to_integer(struct val *); >>> void to_string(struct val *); >>> int yyerror(const char *); >>> int yylex(void); >>> -int yyparse(void); >>>=20 >>> %} >>=20 >> There are a lot more than just this unfortunately (I'm working on >> a complete patchset). >> This breakage really makes me think that yacc isn't being built at >> the right time or pathed properly in the build system. >=20 > The complete patch set is there: > http://people.freebsd.org/~bapt/fix-after-yacc.diff > (clang seems to not detect those redudant warning, while gcc = complains) >=20 > I'm waiting for review before committing) >=20 > Thanks for this fix I'll remove it from my patchset Yeah, that looks about right (I was about 4/5 of the way there, = but you beat me to the punch :)..). Cheers! -Garrett=