From owner-freebsd-stable@FreeBSD.ORG Wed Aug 13 20:26:13 2008 Return-Path: Delivered-To: stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9D313106566C; Wed, 13 Aug 2008 20:26:13 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id 336398FC12; Wed, 13 Aug 2008 20:26:13 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [IPv6:::1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m7DKQ4wX096034; Wed, 13 Aug 2008 16:26:04 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: freebsd-stable@freebsd.org Date: Wed, 13 Aug 2008 15:48:37 -0400 User-Agent: KMail/1.9.7 References: <200808130022.m7D0MCaK082721@freefall.freebsd.org> <20080813134210.GG1803@deviant.kiev.zoral.com.ua> In-Reply-To: <20080813134210.GG1803@deviant.kiev.zoral.com.ua> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200808131548.37571.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [IPv6:::1]); Wed, 13 Aug 2008 16:26:04 -0400 (EDT) X-Virus-Scanned: ClamAV 0.93.1/8027/Wed Aug 13 14:31:07 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=AWL,BAYES_00,NO_RELAYS autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: Kostik Belousov , amd64@freebsd.org, stable@freebsd.org, peter@freebsd.org Subject: Re: Pending MFC Reminder [cvs commit: src/sys/amd64/amd64 cpu_switch.S genassym.c src/sys/amd64/ia32 ia32_signal.c src/sys/amd64/include pcb.h src/sys/amd64/linux32 linux32_machdep.c] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Aug 2008 20:26:13 -0000 On Wednesday 13 August 2008 09:42:10 am Kostik Belousov wrote: > On Wed, Aug 13, 2008 at 12:22:12AM +0000, MFC Notification Service wrote: > > Dear Konstantin Belousov, > > > > As you have requested, I would like to notify you that you have > > committed a change that may be MFC'ed now, as a testing period > > specified at the time of that commit is over. > > > > For reference purposes following is a copy of your original > > commit message. > > > > Regards, > > > > Maxim "MFC Reminder" Sobolev > > P.S. Please contact Maxim Sobolev if you > > believe that you received this message due to an error. > > > > kib 2008-07-30 11:30:55 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/amd64/amd64 cpu_switch.S genassym.c > > sys/amd64/ia32 ia32_signal.c > > sys/amd64/include pcb.h > > sys/amd64/linux32 linux32_machdep.c > > Log: > > SVN rev 180992 on 2008-07-30 11:30:55Z by kib > > > > Bring back the save/restore of the %ds, %es, %fs and %gs registers for > > the 32bit images on amd64. > > > > Change the semantic of the PCB_32BIT pcb flag to request the context > > switch code to operate on the segment registers. Its previous meaning > > of saving or restoring the %gs base offset is assigned to the new > > PCB_GS32BIT flag. > > > > FreeBSD 32bit image activator sets the PCB_32BIT flag, while Linux 32bit > > emulation sets PCB_32BIT | PCB_GS32BIT. > > > > Reviewed by: peter > > MFC after: 2 weeks > > > > Revision Changes Path > > 1.162 +29 -18 src/sys/amd64/amd64/cpu_switch.S > > 1.169 +1 -0 src/sys/amd64/amd64/genassym.c > > 1.18 +1 -1 src/sys/amd64/ia32/ia32_signal.c > > 1.65 +1 -0 src/sys/amd64/include/pcb.h > > 1.47 +1 -1 src/sys/amd64/linux32/linux32_machdep.c > > This appeared to be a not quite trivial MFC to perform. The reason for > complication is that the HEAD code for amd64 context switch was changed, > in particular by the r177535 by peter@. > > The r177535 formally requires r177533 for the definition of the > TDP_KTHREAD symbol for asm. The definition is needed for optimization > of the context switch to the "pure kernel thread", introduced in > r173004 that is not MFCed either, and possibly never be. > > I do not want to backport the code to the old context switch, that would > mean a rewrite from scratch. Instead, I merged the r177535 (optimization > of context switch by peter@), and commented out corresponding test in > the cpu_switch.S for the TDP_KTHREAD. > > I would be glad to get an opinions on the approach taken, and especially > for the wider testing on the RELENG_7/amd64. The problem better be > solved for 7.1. > > The patch: > http://people.freebsd.org/~kib/misc/amd64_ctx.releng_7.4.patch FYI, in 6.x and 7.x there is P_KTHREAD in p_flags that is what TDP_KTHREAD replaced. -- John Baldwin