From owner-freebsd-mobile  Mon Apr  3 11:20: 7 2000
Delivered-To: freebsd-mobile@freebsd.org
Received: from tasogare.imasy.or.jp (tasogare.imasy.or.jp [202.227.24.5])
	by hub.freebsd.org (Postfix) with ESMTP id 83A4A37BF98
	for <freebsd-mobile@FreeBSD.ORG>; Mon,  3 Apr 2000 11:20:02 -0700 (PDT)
	(envelope-from iwasaki@jp.FreeBSD.org)
Received: from localhost (isdn30.imasy.or.jp [202.227.24.222])
	by tasogare.imasy.or.jp (8.9.3+3.2W/3.7W-tasogare/smtpfeed 1.01) with ESMTP id DAA11822;
	Tue, 4 Apr 2000 03:19:38 +0900 (JST)
	(envelope-from iwasaki@jp.FreeBSD.org)
Message-Id: <200004031819.DAA11822@tasogare.imasy.or.jp>
To: imp@village.org
Cc: iwasaki@jp.FreeBSD.org, freebsd-mobile@FreeBSD.ORG
Subject: Re: Call for review: Wildcard entry support 
In-Reply-To: Your message of "Mon, 03 Apr 2000 10:28:54 -0600"
	<200004031628.KAA61924@harmony.village.org>
References: <200004031628.KAA61924@harmony.village.org>
X-Mailer: Mew version 1.93 on Emacs 19.34 / Mule 2.3 (SUETSUMUHANA)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Date: Tue, 04 Apr 2000 03:19:36 +0900
From: Mitsuru IWASAKI <iwasaki@jp.FreeBSD.org>
X-Dispatcher: imput version 980905(IM100)
Lines: 31
Sender: owner-freebsd-mobile@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

> : I think it is better to have them because more than two available
> : config lines are needed if two cards use the same generic entry.
> : Also, I'm expecting that a lot of normal cards can be supported by
> : generic entries and this will cause few new card to be added.
> : In this case, the `just in case' entries make sense.
> 
> Does the generic entry give you one of the cards, unspecified in
> number, or does it give you an unlimited number of them.  If the form,
> I can see why you'd want to have more just in case.  If the latter,
> then I don't see the point.  If the generic code can eliminate a large
> number of entries (say all of the modems), then having a couple of
> extra lines shouldn't be a huge deal.  They seem like they might be
> nops to me, which is why I ask.

I was expecting the latter but actual code seems to say the former.
Currently generic entry can support only one card at the same time,
so the extra lines make sense only if the same type of card (but
different card) uses the same configuraion.  Changing 2 lines of
	conf->inuse = 1;
to
	if (cp->func_id == 0)
		conf->inuse = 1;
in cardd.c is my expected behavior, an unlimited number of cards can
share one generic entry using different configuration for each cards.

> : No, I was not going to beat you :-)
> 
> Ah.  I mean beat as in "get there first" not beat as in "assualt or do
> bodily harm to".

OK, I learned a useful expression :)


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-mobile" in the body of the message