From owner-cvs-ports@FreeBSD.ORG Fri Jun 3 15:54:25 2011 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A93051065674 for ; Fri, 3 Jun 2011 15:54:25 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from relay01.pair.com (relay01.pair.com [209.68.5.15]) by mx1.freebsd.org (Postfix) with SMTP id 4CA348FC13 for ; Fri, 3 Jun 2011 15:54:24 +0000 (UTC) Received: (qmail 65070 invoked from network); 3 Jun 2011 15:54:23 -0000 Received: from 77.116.254.155 (HELO 77.116.254.155.wireless.dyn.drei.com) (77.116.254.155) by relay01.pair.com with SMTP; 3 Jun 2011 15:54:23 -0000 X-pair-Authenticated: 77.116.254.155 Date: Fri, 3 Jun 2011 17:54:24 +0200 (CEST) From: Gerald Pfeifer To: Ruslan Mahmatkhanov In-Reply-To: <4DE7FA38.2040307@yandex.ru> Message-ID: References: <201106021631.p52GVgHM038132@repoman.freebsd.org> <20110602165708.GA61311@atarininja.org> <4DE7D4B4.3040302@yandex.ru> <20110602195248.GA62894@atarininja.org> <4DE7FA38.2040307@yandex.ru> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: cvs-ports@FreeBSD.org, Wesley Shields , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net/erlyvideo Makefile pkg-plist X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jun 2011 15:54:25 -0000 On Fri, 3 Jun 2011, Ruslan Mahmatkhanov wrote: >>> I'm fully agree with that findelete stuff, so here is the patch, >>> thanks for pointing out. Surely i picked this construct in some >>> another port, but can't recall which one. > Here is complete (?) list of them - 112 ports: > http://pastebin.com/7abRca2h > > I can prepare patches if wish What's more important than that, I think, is addressing this in a more systematic manner to prevent new occurrences from slipping in: So I went ahead and filed PR ports/157566: portlint: Warng about use of ${FIND}...${XARGS} {RM}. Perhaps you can cook up a patch? :-) In my experience, the portlint maintainer is very responsive in making this kind of change or accepting/fixing proposed patches, and I encourage all of us doing it Gerald