From owner-freebsd-stable Fri Mar 22 8:41:41 2002 Delivered-To: freebsd-stable@freebsd.org Received: from ebb.errno.com (ebb.errno.com [66.127.85.87]) by hub.freebsd.org (Postfix) with ESMTP id B6D7E37B419; Fri, 22 Mar 2002 08:41:33 -0800 (PST) Received: from melange (melange.errno.com [66.127.85.82]) (authenticated bits=0) by ebb.errno.com (8.12.1/8.12.1) with ESMTP id g2MGfQNN005350 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO); Fri, 22 Mar 2002 08:41:27 -0800 (PST)?g (envelope-from sam@errno.com)œ Message-ID: <407801c1d1c0$74867760$52557f42@errno.com> From: "Sam Leffler" To: , "Ian Dowse" Cc: "Jon Larssen" , , References: <200203221248.g2MCmib27911@freebsd.dk> Subject: Re: Is ATA partially broken in -STABLE? Date: Fri, 22 Mar 2002 08:41:44 -0800 Organization: Errno Consulting MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.50.4807.1700 X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4807.1700 Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Actually, two races were reintroduced--one for disks and one for cdroms. Please see my note with a tested patch. Sam ----- Original Message ----- From: "Søren Schmidt" To: "Ian Dowse" Cc: "Jon Larssen" ; ; Sent: Friday, March 22, 2002 4:48 AM Subject: Re: Is ATA partially broken in -STABLE? > It seems Ian Dowse wrote: > > In message <200203220933.g2M9XGT90073@freebsd.dk>, Søren Schmidt writes: > > >Its a known problem, the old way of solving it was: > > > > Ok - is there a good reason for not using spl calls to block the > > interrupt until the tsleep(), or is it just an oversight? I guess > > maybe you are trying to avoid the delay associated with deferring > > the interrupt, but it must open up a number of races, especially > > if the ATA interrupt line is shared with something else. > > The driver used asleep to avoid the race before the MFC, one of > those got lost in the MFC, sorry... > > -Søren > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-stable" in the body of the message > > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message