From owner-cvs-src@FreeBSD.ORG Mon Jul 30 09:21:41 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D2C8116A417; Mon, 30 Jul 2007 09:21:41 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.freebsd.org (Postfix) with ESMTP id 5D0EA13C478; Mon, 30 Jul 2007 09:21:41 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (localhost [127.0.0.1]) by spam.des.no (Postfix) with ESMTP id 62841208D; Mon, 30 Jul 2007 11:21:37 +0200 (CEST) X-Spam-Tests: AWL X-Spam-Learn: disabled X-Spam-Score: 0.0/3.0 X-Spam-Checker-Version: SpamAssassin 3.2.1 (2007-05-02) on tim.des.no Received: from ds4.des.no (des.no [80.203.243.180]) by smtp.des.no (Postfix) with ESMTP id 49750208C; Mon, 30 Jul 2007 11:21:37 +0200 (CEST) Received: by ds4.des.no (Postfix, from userid 1001) id 39F9C84467; Mon, 30 Jul 2007 11:21:37 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Warner Losh References: <20070729214715.I31116@maildrop.int.zabbadoz.net> <20070729160246.A86779@ns1.feral.com> <86zm1ejrat.fsf@ds4.des.no> <20070730.025750.41720145.imp@bsdimp.com> Date: Mon, 30 Jul 2007 11:21:37 +0200 In-Reply-To: <20070730.025750.41720145.imp@bsdimp.com> (Warner Losh's message of "Mon\, 30 Jul 2007 02\:57\:50 -0600 \(MDT\)") Message-ID: <86k5sijlge.fsf@ds4.des.no> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.1 (berkeley-unix) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Cc: cvs-src@freebsd.org, bz@freebsd.org, src-committers@freebsd.org, mjacob@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netinet tcp_input.c tcp_usrreq.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jul 2007 09:21:41 -0000 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Warner Losh writes: > Thank you for your opinion. However, make universe is not worthless. > If doing one, and checking the output for errors, isn't sufficient to > get tinderbox to not whine, then tinderbox is broken. Thank you for *your* opinion, but the tinderbox is not at fault here. The fact of the matter is that LINT is broken, as a simple 'make buildkernel KERNCONF=3DLINT' will show. The attached patch unbreaks the build. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=tcpstates.diff Index: sys/netinet/tcp_fsm.h =================================================================== RCS file: /home/ncvs/src/sys/netinet/tcp_fsm.h,v retrieving revision 1.19 diff -u -r1.19 tcp_fsm.h --- sys/netinet/tcp_fsm.h 11 May 2007 10:50:31 -0000 1.19 +++ sys/netinet/tcp_fsm.h 30 Jul 2007 09:08:26 -0000 @@ -102,7 +102,7 @@ #endif #ifdef TCPSTATES -const char *tcpstates[] = { +static const char *tcpstates[] = { "CLOSED", "LISTEN", "SYN_SENT", "SYN_RCVD", "ESTABLISHED", "CLOSE_WAIT", "FIN_WAIT_1", "CLOSING", "LAST_ACK", "FIN_WAIT_2", "TIME_WAIT", Index: sys/netinet/tcp_usrreq.c =================================================================== RCS file: /home/ncvs/src/sys/netinet/tcp_usrreq.c,v retrieving revision 1.159 diff -u -r1.159 tcp_usrreq.c --- sys/netinet/tcp_usrreq.c 29 Jul 2007 01:31:33 -0000 1.159 +++ sys/netinet/tcp_usrreq.c 30 Jul 2007 09:08:19 -0000 @@ -87,10 +87,6 @@ /* * TCP protocol interface to socket abstraction. */ -#ifdef TCPDEBUG -extern const char *tcpstates[]; -#endif - static int tcp_attach(struct socket *); static int tcp_connect(struct tcpcb *, struct sockaddr *, struct thread *td); Index: sys/netipx/spx_debug.c =================================================================== RCS file: /home/ncvs/src/sys/netipx/spx_debug.c,v retrieving revision 1.18 diff -u -r1.18 spx_debug.c --- sys/netipx/spx_debug.c 11 May 2007 10:38:34 -0000 1.18 +++ sys/netipx/spx_debug.c 30 Jul 2007 09:19:46 -0000 @@ -69,6 +69,8 @@ #include #include +#define TCPSTATES /* for logging */ + #include #include Index: sys/netipx/spx_debug.h =================================================================== RCS file: /home/ncvs/src/sys/netipx/spx_debug.h,v retrieving revision 1.17 diff -u -r1.17 spx_debug.h --- sys/netipx/spx_debug.h 11 May 2007 10:38:34 -0000 1.17 +++ sys/netipx/spx_debug.h 30 Jul 2007 09:12:44 -0000 @@ -95,7 +95,6 @@ #ifdef _KERNEL extern char *prurequests[]; extern char *sanames[]; -extern char *tcpstates[]; void spx_trace(short act, u_char ostate, struct spxpcb *sp, struct spx *si, int req); --=-=-=--