From owner-freebsd-stable@FreeBSD.ORG Thu Mar 15 13:26:15 2007 Return-Path: X-Original-To: freebsd-stable@freebsd.org Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1E94416A400 for ; Thu, 15 Mar 2007 13:26:15 +0000 (UTC) (envelope-from grafan@gmail.com) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.172]) by mx1.freebsd.org (Postfix) with ESMTP id 9F59013C455 for ; Thu, 15 Mar 2007 13:26:13 +0000 (UTC) (envelope-from grafan@gmail.com) Received: by ug-out-1314.google.com with SMTP id 71so318953ugh for ; Thu, 15 Mar 2007 06:26:12 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=Q5Ladr6vldPDcIlOScDK6oUJJ4lL+ko57DbUr8n7WgrtlJ6TAjMb+BnGrC2DTtbWOuOQMyMK/SSsHWETeBkveBNHJj9quIauMDtK1nBb5kazVoIgiCJ9bL7TUMcqWMsD8LnGUNezGIke/qmPvC2w8oKjGyMbaZ0zghuCjkfAwoE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=JaIZnCNDpiYXvhCtAXngs5wIz7CXCuUcun40lf71IZeNQI0hu3pcB20I2eCJJryD/RVRcxnQPSr0ILb1ll+A6YAi/dLl+NNPFkf+OQ/aLaYe8serdFvBpUHIf/PQH6u0t76q395AdEUwm1Mel3MywmGmIWTmEqQoYicnhIHK1iw= Received: by 10.78.120.6 with SMTP id s6mr318100huc.1173963417287; Thu, 15 Mar 2007 05:56:57 -0700 (PDT) Received: by 10.78.202.1 with HTTP; Thu, 15 Mar 2007 05:56:57 -0700 (PDT) Message-ID: <6eb82e0703150556u39ee7769s29fa73cbbbc25811@mail.gmail.com> Date: Thu, 15 Mar 2007 20:56:57 +0800 From: "Rong-en Fan" To: "Jack Vogel" In-Reply-To: <2a41acea0701221030x52dd8821pd858ae7e6740ce92@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <2a41acea0701171258k16b4c6ebuf1d4794b89d0749b@mail.gmail.com> <20070120065321.DB61216A405@hub.freebsd.org> <2a41acea0701201435g6f960b40r3cf0552d87ab2bfd@mail.gmail.com> <20070122083506.GW4485@FreeBSD.org> <2a41acea0701221030x52dd8821pd858ae7e6740ce92@mail.gmail.com> Cc: Bill Paul , jon.otterholm@ide.resurscentrum.se, Gleb Smirnoff , freebsd-stable@freebsd.org, freebsd-current@freebsd.org Subject: Re: Lenovo X60 em workaround X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Mar 2007 13:26:15 -0000 On 1/23/07, Jack Vogel wrote: > > Hey Gleb, > > Acknowledge... I can do better than that, I have a fix for this problem, and > its not temporary. Here is the code change (not a patch, I'm very busy), > its in hardware_init, should be obvious how to patch: > > /* Make sure we have a good EEPROM before we read from it */ > if (e1000_validate_nvm_checksum(&adapter->hw) < 0) { > /* > ** Some PCI-E parts fail the first check due to > ** the link being in sleep state, call it again, > ** if it fails a second time its a real issue. > */ > if (e1000_validate_nvm_checksum(&adapter->hw) < 0) { > device_printf(dev, > "The EEPROM Checksum Is Not Valid\n"); > return (EIO); > } > } > > This is already checked into my code base at Intel, I've just been too > busy to do anything with it, be my guest if you wish to check it in after > testing... I accidentally found this : http://www-307.ibm.com/pc/support/site.wss/document.do?sitestyle=lenovo&lndocid=MIGR-67166 which patches the eeprom. And it solves by problem. Regards, Rong-En Fan