From owner-svn-src-all@FreeBSD.ORG  Thu Jul  1 07:38:17 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8EE6D106564A;
	Thu,  1 Jul 2010 07:38:17 +0000 (UTC)
	(envelope-from kevlo@FreeBSD.org)
Received: from ns.kevlo.org (kevlo.org [220.128.136.52])
	by mx1.freebsd.org (Postfix) with ESMTP id 1FF948FC0A;
	Thu,  1 Jul 2010 07:38:16 +0000 (UTC)
Received: from [127.0.0.1] (kevlo@kevlo.org [220.128.136.52])
	by ns.kevlo.org (8.14.3/8.14.3) with ESMTP id o617MCRc017034;
	Thu, 1 Jul 2010 15:22:13 +0800 (CST)
From: Kevin Lo <kevlo@FreeBSD.org>
To: Jack Vogel <jfvogel@gmail.com>
In-Reply-To: <AANLkTimNiPk8fe_lvVbgCfgNSMuceW79bsxBqGI-PhDL@mail.gmail.com>
References: <201007010503.o6153O78066276@svn.freebsd.org>
	<AANLkTimNiPk8fe_lvVbgCfgNSMuceW79bsxBqGI-PhDL@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Date: Thu, 01 Jul 2010 15:22:12 +0800
Message-ID: <1277968932.2050.37.camel@nsl>
Mime-Version: 1.0
X-Mailer: Evolution 2.28.3 
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@FreeBSD.org, Kevin Lo <kevlo@FreeBSD.org>,
	svn-src-all@FreeBSD.org, src-committers@FreeBSD.org
Subject: Re: svn commit: r209622 - head/sys/dev/ixgbe
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Jul 2010 07:38:17 -0000

Jack,

This is YOUR problem. First, you committed the code without testing,
glebius@ fixed it after 17 hours. Second, you didn't bring your 
working copy into sync with the latest revision in the repository
and didn't notice build broken was fixed.
I just updated the source and recompiled kernel, found there's broken 
on ixgbe(4). Since the fix is trivial, so I fixed it and wanted to 
test something with the latest kernel. 

        Kevin

Jack Vogel wrote:
> I went to a LOT of trouble setting up a mirror at home and just as I
> went to commit
> the change its updated.
> 
> While I understand the good intentions, please don't do this again. If
> I had been
> unresponsive for days or something I understand, but its been hours,
> and I was
> fixing it.
> 
> Jack
> 
> 
> On Wed, Jun 30, 2010 at 10:03 PM, Kevin Lo <kevlo@freebsd.org> wrote:
>         Author: kevlo
>         Date: Thu Jul  1 05:03:24 2010
>         New Revision: 209622
>         URL: http://svn.freebsd.org/changeset/base/209622
>         
>         Log:
>          Fix build
>         
>         Modified:
>          head/sys/dev/ixgbe/ixgbe.h
>         
>         Modified: head/sys/dev/ixgbe/ixgbe.h
>         ==============================================================================
>         --- head/sys/dev/ixgbe/ixgbe.h  Thu Jul  1 03:48:45 2010
>            (r209621)
>         +++ head/sys/dev/ixgbe/ixgbe.h  Thu Jul  1 05:03:24 2010
>            (r209622)
>         @@ -382,7 +382,6 @@ struct adapter {
>                u32                     link_speed;
>                bool                    link_up;
>                u32                     linkvec;
>         -       int                     advertise;
>         
>                /* Mbuf cluster size */
>                u32                     rx_mbuf_sz; 
>