From owner-cvs-all  Fri Dec  4 00:30:42 1998
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id AAA07562
          for cvs-all-outgoing; Fri, 4 Dec 1998 00:30:42 -0800 (PST)
          (envelope-from owner-cvs-all@FreeBSD.ORG)
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.15.68.22])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id AAA07553;
          Fri, 4 Dec 1998 00:30:38 -0800 (PST)
          (envelope-from bde@godzilla.zeta.org.au)
Received: (from bde@localhost)
	by godzilla.zeta.org.au (8.8.7/8.8.7) id TAA13675;
	Fri, 4 Dec 1998 19:30:10 +1100
Date: Fri, 4 Dec 1998 19:30:10 +1100
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199812040830.TAA13675@godzilla.zeta.org.au>
To: ache@nagual.pp.ru, dillon@apollo.backplane.com
Subject: Re: cvs commit: src/sys/netinet icmp_var.h ip_icmp.c tcp_input.c udp_usrreq.c
Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

>:>   Modified files:
>:>     sys/netinet          icmp_var.h ip_icmp.c tcp_input.c 
>:>                          udp_usrreq.c 
>:
>:Please remove or #ifdef KERNEL
>:#include "opt_icmp_bandlim.h"
>:from icmp_var.h, this file sometimes used in userland applications which
>:are broken now.
>:Function badport_badlim should also be removed of KERNEL #ifdefed.
>:
>:Basically I dislike idea of touching icmp_var.h at all, could you add
>:separate include file for this stuff, please?
>
>    I'll add the #ifdef KERNEL.  I'd gladly move everything out of
>    icmp_var.h if you tell me how to deal with the sysctl initialization 
>    (can I just use the AUTO mode and get rid of the ICMPCTL_MAXID and 
>    ICMP_BANDLI<_INFO junk?) and where to put the badport_bandlim() extern.

Rules for avoiding messes like this:
- Options headers shall never be included in headers.
- Always use OID_AUTO for new sysctls.  (XXX_MAXID and XXX_NAMES
  definitions are never used, so even if you don't use OID_AUTO, the
  only reason to add them is for BSD4.4 compatibility in case we decide
  to throw out phk's reimplementation of sysctl).

Bruce

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message