From owner-freebsd-current@FreeBSD.ORG Wed Jun 16 02:09:02 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C24571065678 for ; Wed, 16 Jun 2010 02:09:02 +0000 (UTC) (envelope-from jhellenthal@gmail.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id 450E88FC17 for ; Wed, 16 Jun 2010 02:09:01 +0000 (UTC) Received: by iwn7 with SMTP id 7so7267106iwn.13 for ; Tue, 15 Jun 2010 19:09:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:openpgp:content-type:content-transfer-encoding; bh=t+xmyPbJgkJYF5aleK9SJPveSLTKIZmaJlozS47GVLg=; b=vqgVQvbDMWlL6PQRGsx0ShOmC7kBDxf4Q/wHuwnWxH6eXDfRqvgA6+k9WAiO8IueRK 2b6quSQjZZCtGahNbDfWS+zvgDeKz/50HHRcKKGBvtcxLdyk4voknZucu6cAV4Mv3l67 cJWGWNwPooxgerSnNI0TGaCApWx9SuaHtQiEw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:openpgp:content-type :content-transfer-encoding; b=pV1db/lu1PWPQD0CsBML7dc2ICxtDo60u8JGI4ltm0HegzBaTENhkGHpKY2WkHZR9B N2Qhrh0effQA7rmuqEhXCuknXAqa8IiWOvalq8wt9zgNv2TeDTqlV/FcU5ByXR7zD+UB olQU/6ziwgqV/9S0i6k+8sL/9J7DrVYBk35T0= Received: by 10.231.173.145 with SMTP id p17mr9000862ibz.32.1276654140627; Tue, 15 Jun 2010 19:09:00 -0700 (PDT) Received: from centel.dataix.local (adsl-99-181-128-180.dsl.klmzmi.sbcglobal.net [99.181.128.180]) by mx.google.com with ESMTPS id r12sm28656154ibi.20.2010.06.15.19.08.43 (version=SSLv3 cipher=RC4-MD5); Tue, 15 Jun 2010 19:08:54 -0700 (PDT) Sender: "J. Hellenthal" Message-ID: <4C18322A.6050007@dataix.net> Date: Tue, 15 Jun 2010 22:08:42 -0400 From: jhell User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.1.9) Gecko/20100515 Thunderbird MIME-Version: 1.0 To: Brandon Gooch References: <4C18304A.1080601@dataix.net> In-Reply-To: <4C18304A.1080601@dataix.net> X-Enigmail-Version: 1.0.1 OpenPGP: id=89D8547E Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: FreeBSD Current , jilles@stack.nl Subject: Re: [MFC REQUEST] Filename completion in sh(1) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jun 2010 02:09:02 -0000 On 06/15/2010 22:00, jhell wrote: > On 06/15/2010 21:14, Brandon Gooch wrote: >> I discovered a few moments ago that filename completion had been >> committed to HEAD[1]!!! > >> This is a (seemingly) small, yet VERY useful addition, and, of course >> I'm so grateful to Guy Yur and Jilles for getting this into the tree >> :) > >> I would like to make an "official" request that this feature be MFC'd >> to 8-STABLE as soon as reasonably possible. > >> Again, my thanks to you both for your work! > >> -Brandon > >> [1] http://svn.freebsd.org/viewvc/base?view=revision&revision=209221 > > Here is a diff from stable/8/bin/sh r209146 -> head/bin/sh. This is > quite a large difference among the two with the following diffstats. > > 44 files changed, 1214 insertions(+), 728 deletions(-) > > This is untested, use at your own risk. > Actually, I lied. I have just tested it and it does not compile for the following errors: /usr/src/bin/sh/histedit.c: In function 'histedit': /usr/src/bin/sh/histedit.c:124: error: '_el_fn_sh_complete' undeclared (first use in this function) /usr/src/bin/sh/histedit.c:124: error: (Each undeclared identifier is reported only once /usr/src/bin/sh/histedit.c:124: error: for each function it appears in.) But I do not have time to look into this further until tommorow. Regards, -- jhell