From owner-p4-projects@FreeBSD.ORG  Tue Jun 19 21:52:33 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id A6F7C16A468; Tue, 19 Jun 2007 21:52:33 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 753DD16A46B
	for <perforce@freebsd.org>; Tue, 19 Jun 2007 21:52:33 +0000 (UTC)
	(envelope-from andrew@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41])
	by mx1.freebsd.org (Postfix) with ESMTP id 63F8213C46A
	for <perforce@freebsd.org>; Tue, 19 Jun 2007 21:52:33 +0000 (UTC)
	(envelope-from andrew@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l5JLqX23034951
	for <perforce@freebsd.org>; Tue, 19 Jun 2007 21:52:33 GMT
	(envelope-from andrew@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l5JLqXPu034939
	for perforce@freebsd.org; Tue, 19 Jun 2007 21:52:33 GMT
	(envelope-from andrew@freebsd.org)
Date: Tue, 19 Jun 2007 21:52:33 GMT
Message-Id: <200706192152.l5JLqXPu034939@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	andrew@freebsd.org using -f
From: Andrew Turner <andrew@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 121993 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Jun 2007 21:52:34 -0000

http://perforce.freebsd.org/chv.cgi?CH=121993

Change 121993 by andrew@andrew_hermies on 2007/06/19 21:52:10

	Use INT32_{MIN,MAX} and UINT32_MAX rather than magic numbers
	Replace snprintf with a const char *

Affected files ...

.. //depot/projects/soc2007/andrew-update/lib/facund_object.c#2 edit
.. //depot/projects/soc2007/andrew-update/lib/facund_server.c#6 edit

Differences ...

==== //depot/projects/soc2007/andrew-update/lib/facund_object.c#2 (text+ko) ====

@@ -324,7 +324,7 @@
 		int32_t data;
 		const char *errstr;
 
-		data = strtonum(value, (-0x7fffffff - 1), 0x7fffffff, &errstr);
+		data = strtonum(value, INT32_MIN, INT32_MAX, &errstr);
 		if (errstr != NULL) {
 			/* TODO: Error handeling */
 			return -1;
@@ -335,7 +335,7 @@
 		uint32_t data;
 		const char *errstr;
 
-		data = strtonum(value, 0, 0xffffffffU, &errstr);
+		data = strtonum(value, 0, UINT32_MAX, &errstr);
 		if (errstr != NULL) {
 			/* TODO: Error handeling */
 			return -1;

==== //depot/projects/soc2007/andrew-update/lib/facund_server.c#6 (text+ko) ====

@@ -202,7 +202,6 @@
 facund_server_end_tag(void *data, const XML_Char *name)
 {
 	struct facund_conn *conn;
-	char str[1024];
 
 	printf("< %s\n", name);
 	conn = data;
@@ -223,8 +222,8 @@
 			conn->call_arg = conn->call_arg->obj_parent;
 		}
 	} else if (strcmp(name, "facund-client") == 0) {
-		snprintf(str, 1024, "</facund-server>");
-		facund_send(conn, str, strlen(str));
+		const char *msg = "</facund-server>";
+		facund_send(conn, msg, strlen(msg));
 		conn->close = 1;
 	}
 }