From owner-cvs-all Fri Dec 4 00:37:48 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id AAA08170 for cvs-all-outgoing; Fri, 4 Dec 1998 00:37:48 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from nagual.pp.ru (lsd.relcom.eu.net [193.125.27.73]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id AAA08165; Fri, 4 Dec 1998 00:37:45 -0800 (PST) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.9.1/8.9.1) id LAA21734; Fri, 4 Dec 1998 11:37:16 +0300 (MSK) (envelope-from ache) Message-ID: <19981204113716.B19232@nagual.pp.ru> Date: Fri, 4 Dec 1998 11:37:16 +0300 From: "Andrey A. Chernov" To: Bruce Evans , dillon@apollo.backplane.com Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG Subject: Re: cvs commit: src/sys/netinet icmp_var.h ip_icmp.c tcp_input.c udp_usrreq.c Mail-Followup-To: Bruce Evans , dillon@apollo.backplane.com, cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG References: <199812040830.TAA13675@godzilla.zeta.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.93.2i In-Reply-To: <199812040830.TAA13675@godzilla.zeta.org.au>; from bde@zeta.org.au on Fri, Dec 04, 1998 at 07:30:10PM +1100 Organization: Biomechanoid Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Fri, Dec 04, 1998 at 07:30:10PM +1100, Bruce Evans wrote: > Rules for avoiding messes like this: > - Options headers shall never be included in headers. I agree with this. If you need optional header and some stuff in the header depend on it, include it before the header, not into. > - Always use OID_AUTO for new sysctls. (XXX_MAXID and XXX_NAMES > definitions are never used, so even if you don't use OID_AUTO, the > only reason to add them is for BSD4.4 compatibility in case we decide > to throw out phk's reimplementation of sysctl). Hmm. Can't say anything. -- Andrey A. Chernov http://www.nagual.pp.ru/~ache/ MTH/SH/HE S-- W-- N+ PEC>+ D A a++ C G>+ QH+(++) 666+>++ Y To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message