From owner-freebsd-current@FreeBSD.ORG Wed Jun 16 02:17:43 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 158201065673 for ; Wed, 16 Jun 2010 02:17:43 +0000 (UTC) (envelope-from jamesbrandongooch@gmail.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id CDDA08FC16 for ; Wed, 16 Jun 2010 02:17:42 +0000 (UTC) Received: by iwn7 with SMTP id 7so7275744iwn.13 for ; Tue, 15 Jun 2010 19:17:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=cpcX/txBHZs9VKI+F6TzsPhKbDeIAB2SvMHrUlSg5wA=; b=Br6Ge/EnW05XTOnfPKEvfMbuj5xj/mhfvOGatOctXxpddwOcJia89sCHdkSUHR+0G6 WC6ud/yv8WZcX/Bf8vUVO+ouj2OOvS3IJAgwzkPZpVB8Xl8gg1Hnt32v27fndnOEOPyY MYTNj+4eB+fJ8AqfGBpnvIlD+kUTC5jv8MCms= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=ZHdaH8sikuRK8OfvkfcVrIA456uG/HXmlRgTCgply2ASaSZ7eIKDLvR5aA0qh8nRg5 VDcZA0/Tu8kWFntZxug8zHVlbRDtxtw3Zu/javwJ4PGTtECV5NshzC2k33gRv+igtXfj ZHT05BJ5cYB+hi/9HVHlY9Nahy+Yy8HR9BGWQ= MIME-Version: 1.0 Received: by 10.231.149.145 with SMTP id t17mr9167210ibv.25.1276654662081; Tue, 15 Jun 2010 19:17:42 -0700 (PDT) Received: by 10.231.182.212 with HTTP; Tue, 15 Jun 2010 19:17:42 -0700 (PDT) In-Reply-To: <4C18322A.6050007@dataix.net> References: <4C18304A.1080601@dataix.net> <4C18322A.6050007@dataix.net> Date: Tue, 15 Jun 2010 21:17:42 -0500 Message-ID: From: Brandon Gooch To: jhell Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: FreeBSD Current , jilles@stack.nl Subject: Re: [MFC REQUEST] Filename completion in sh(1) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jun 2010 02:17:43 -0000 On Tue, Jun 15, 2010 at 9:08 PM, jhell wrote: > On 06/15/2010 22:00, jhell wrote: >> On 06/15/2010 21:14, Brandon Gooch wrote: >>> I discovered a few moments ago that filename completion had been >>> committed to HEAD[1]!!! >> >>> This is a (seemingly) small, yet VERY useful addition, and, of course >>> I'm so grateful to Guy Yur and Jilles for getting this into the tree >>> :) >> >>> I would like to make an "official" request that this feature be MFC'd >>> to 8-STABLE as soon as reasonably possible. >> >>> Again, my thanks to you both for your work! >> >>> -Brandon >> >>> [1] http://svn.freebsd.org/viewvc/base?view=3Drevision&revision=3D20922= 1 >> >> Here is a diff from stable/8/bin/sh r209146 -> head/bin/sh. This is >> quite a large difference among the two with the following diffstats. >> >> =A044 files changed, 1214 insertions(+), 728 deletions(-) >> >> This is untested, use at your own risk. >> > > Actually, I lied. I have just tested it and it does not compile for the > following errors: > > /usr/src/bin/sh/histedit.c: In function 'histedit': > /usr/src/bin/sh/histedit.c:124: error: '_el_fn_sh_complete' undeclared > (first use in this function) > /usr/src/bin/sh/histedit.c:124: error: (Each undeclared identifier is > reported only once > /usr/src/bin/sh/histedit.c:124: error: for each function it appears in.) > > But I do not have time to look into this further until tommorow. Thanks for this jhell! It appears that a C header file is missing from /usr/include; the function declaration is "histedit.h". No problem, just `make install` in /usr/src/include and it should build. -Brandon