From owner-freebsd-current@FreeBSD.ORG Wed Jun 16 02:23:54 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 790411065670 for ; Wed, 16 Jun 2010 02:23:54 +0000 (UTC) (envelope-from jamesbrandongooch@gmail.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id 3BC358FC14 for ; Wed, 16 Jun 2010 02:23:53 +0000 (UTC) Received: by iwn7 with SMTP id 7so7282275iwn.13 for ; Tue, 15 Jun 2010 19:23:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=MYPV9cFiS5M/wwxNlBp+eKQpp5ZTEK4ncgnjvbAoqec=; b=QEwOvoC1jRAGtjPLe3aPIoYzR0LxiDAFXJelFT7nDdkaJwR+z7ZFBF5JEq5wwdBGDc IjOmUHExk+AHcbjSuJd3VUhqWoMtSJC9i50M2Grqq5+OE9iKriS5Q380u9fTlTBBMplo 6us2JpcINrmMbatPD4WlWYO4P34n1H2Oe5wAk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=KCDFKI4dfcYW1AKIC/zlkJiye9i1qjmrofBdURS3o+qMGtv+5lgibgmwHH5SE1FZTI dmjeJbywA8iu7FcQSZ7Gxwkfn81E0OeFFk4SP56wckL4UH0Z+n8tKy+d33XAYAmmSnF6 sN4OacNm5QoOCVinxZXdCBzekv6RNn/Py4uvo= MIME-Version: 1.0 Received: by 10.231.170.201 with SMTP id e9mr8533534ibz.119.1276655033528; Tue, 15 Jun 2010 19:23:53 -0700 (PDT) Received: by 10.231.182.212 with HTTP; Tue, 15 Jun 2010 19:23:53 -0700 (PDT) In-Reply-To: References: <4C18304A.1080601@dataix.net> <4C18322A.6050007@dataix.net> Date: Tue, 15 Jun 2010 21:23:53 -0500 Message-ID: From: Brandon Gooch To: jhell Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: FreeBSD Current , jilles@stack.nl Subject: Re: [MFC REQUEST] Filename completion in sh(1) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jun 2010 02:23:54 -0000 On Tue, Jun 15, 2010 at 9:17 PM, Brandon Gooch wrote: > On Tue, Jun 15, 2010 at 9:08 PM, jhell wrote: >> On 06/15/2010 22:00, jhell wrote: >>> On 06/15/2010 21:14, Brandon Gooch wrote: >>>> I discovered a few moments ago that filename completion had been >>>> committed to HEAD[1]!!! >>> >>>> This is a (seemingly) small, yet VERY useful addition, and, of course >>>> I'm so grateful to Guy Yur and Jilles for getting this into the tree >>>> :) >>> >>>> I would like to make an "official" request that this feature be MFC'd >>>> to 8-STABLE as soon as reasonably possible. >>> >>>> Again, my thanks to you both for your work! >>> >>>> -Brandon >>> >>>> [1] http://svn.freebsd.org/viewvc/base?view=3Drevision&revision=3D2092= 21 >>> >>> Here is a diff from stable/8/bin/sh r209146 -> head/bin/sh. This is >>> quite a large difference among the two with the following diffstats. >>> >>> =A044 files changed, 1214 insertions(+), 728 deletions(-) >>> >>> This is untested, use at your own risk. >>> >> >> Actually, I lied. I have just tested it and it does not compile for the >> following errors: >> >> /usr/src/bin/sh/histedit.c: In function 'histedit': >> /usr/src/bin/sh/histedit.c:124: error: '_el_fn_sh_complete' undeclared >> (first use in this function) >> /usr/src/bin/sh/histedit.c:124: error: (Each undeclared identifier is >> reported only once >> /usr/src/bin/sh/histedit.c:124: error: for each function it appears in.) >> >> But I do not have time to look into this further until tommorow. > > Thanks for this jhell! > > It appears that a C header file is missing from /usr/include; the > function declaration is "histedit.h". > > No problem, just `make install` in /usr/src/include and it should build. > > -Brandon Oh, I see. The diff doesn't include the change(s) to histedit.h :( oh well, thanks anyway! -Brandon