From owner-freebsd-ports@FreeBSD.ORG Thu Nov 8 09:13:45 2012 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5ECB62C1 for ; Thu, 8 Nov 2012 09:13:45 +0000 (UTC) (envelope-from gahr@FreeBSD.org) Received: from cpanel09.rubas.ch (cpanel09.rubas.ch [195.182.222.79]) by mx1.freebsd.org (Postfix) with ESMTP id 0AD4A8FC14 for ; Thu, 8 Nov 2012 09:13:44 +0000 (UTC) Received: from 175-3.192-178.cust.bluewin.ch ([178.192.3.175]:61370 helo=gahrfit.gahr.ch) by cpanel09.rubas.ch with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.80) (envelope-from ) id 1TWOB6-001XRl-SV; Thu, 08 Nov 2012 10:13:37 +0100 Date: Thu, 8 Nov 2012 10:13:33 +0100 From: Pietro Cerutti To: Joseph a Nagy Jr Subject: Re: tk85 Port Maintenance Message-ID: <20121108091333.GN90275@gahrfit.gahr.ch> References: <20121031152109.GD90275@gahrfit.gahr.ch> <20121031153958.GE90275@gahrfit.gahr.ch> <50915194.6010101@gmail.com> <20121031165507.GF90275@gahrfit.gahr.ch> <509162C9.9060701@gmail.com> <20121102112131.GG90275@gahrfit.gahr.ch> <50968056.8080602@gmail.com> <20121106082040.GM90275@gahrfit.gahr.ch> <509AEACB.1020909@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Xb8pJpF45Qg/t7GZ" Content-Disposition: inline In-Reply-To: <509AEACB.1020909@gmail.com> X-PGP-Key: 0x9571F78E X-PGP-Fingerprint: 1203 92B5 3919 AF84 9B97 28D6 C0C2 6A98 9571 F78E User-Agent: Mutt/1.5.21 (2010-09-15) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cpanel09.rubas.ch X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - FreeBSD.org Cc: ports@freebsd.org, Chris Rees X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: gahr@FreeBSD.org List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Nov 2012 09:13:45 -0000 --Xb8pJpF45Qg/t7GZ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2012-Nov-07, 17:12, Joseph a Nagy Jr wrote: > On 11/06/12 02:20, Pietro Cerutti wrote: > > > * I won't comment on the LICENSE stuff, I don't know enough about it > >=20 > > * XFT_DESC > > This is already defined in bsd.options.desc.mk. I'd say that=20 > > "Xft font library" is ok as a description. > >=20 > > * LIB_DEPENDS+=3D Xft:${PORTSDIR}/x11-fonts/libXft > > This should really be > > USE_XORG+=3D xft > >=20 > > * LIB_DEPENDS=3D tcl${SHORT_TK_VER}${THREADS_SUFFIX}:.... > > If you're ok to wait until I get rid of the -thread slave ports, > > you don't need to bother about this part of the Makefile > >=20 >=20 > svn checked out, svn diff >=20 > http://pastebin.com/kLdUFp9H -XFT_DESC=3D Use Xft fonts +XFT_DESC=3D Xft font library This is not needed. As I said, XFT_DESC is already defined in bsd.options.desc.mk The tr -> ${TR} conversion is also wrong, you're changing what the sed liner is looking for. If you do so, it won't find it anymore. By the way, Tcl/Tk 8.5.13 is bound to be released in the next few days (the first RC is out now, actually). You might want to include the update in your diff :) --=20 Pietro Cerutti The FreeBSD Project gahr@FreeBSD.org PGP Public Key: http://gahr.ch/pgp --Xb8pJpF45Qg/t7GZ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlCbd7wACgkQwMJqmJVx945TPACeP2oN9uJgfRGnSdL+fTgoNfYE VLYAnA+LpKpCcl6KyaWCQTTSY7es3V51 =VQ1D -----END PGP SIGNATURE----- --Xb8pJpF45Qg/t7GZ--