From owner-cvs-ports@FreeBSD.ORG  Fri Jun  3 21:08:56 2011
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35])
	by hub.freebsd.org (Postfix) with ESMTP id 51B621065675;
	Fri,  3 Jun 2011 21:08:56 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from 65-241-43-5.globalsuite.net (hub.freebsd.org
	[IPv6:2001:4f8:fff6::36])
	by mx2.freebsd.org (Postfix) with ESMTP id 8B09516026B;
	Fri,  3 Jun 2011 21:08:05 +0000 (UTC)
Message-ID: <4DE94D34.1040108@FreeBSD.org>
Date: Fri, 03 Jun 2011 14:08:04 -0700
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://SupersetSolutions.com/
User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US;
	rv:1.9.2.17) Gecko/20110429 Thunderbird/3.1.10
MIME-Version: 1.0
To: Steve Wills <swills@FreeBSD.org>
References: <201105292154.p4TLsEsq051959@repoman.freebsd.org>
In-Reply-To: <201105292154.p4TLsEsq051959@repoman.freebsd.org>
X-Enigmail-Version: 1.1.2
OpenPGP: id=1A1ABC84
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/databases/mysql-proxy Makefile
 ports/databases/mysql-proxy/files mysql-proxy.in
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Jun 2011 21:08:56 -0000

The script looks good overall. Is there any reason that the for loop 
could not be in a prestart method? We try to avoid having code run 
unconditionally.


Doug


On 05/29/2011 14:54, Steve Wills wrote:
> swills      2011-05-29 21:54:14 UTC
>
>    FreeBSD ports repository
>
>    Modified files:
>      databases/mysql-proxy Makefile
>      databases/mysql-proxy/files mysql-proxy.in
>    Log:
>    - Fix rc script
>
>    PR:             ports/157332  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=157332
>    Submitted by:   Andrei Lavreniyuk<andy.lavr@gmail.com>
>
>    Revision  Changes    Path
>    1.26      +1 -1      ports/databases/mysql-proxy/Makefile
>    1.3       +2 -2      ports/databases/mysql-proxy/files/mysql-proxy.in
>
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/mysql-proxy/Makefile.diff?&r1=1.25&r2=1.26&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/mysql-proxy/files/mysql-proxy.in.diff?&r1=1.2&r2=1.3&f=h
>



-- 

	Nothin' ever doesn't change, but nothin' changes much.
			-- OK Go

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/