From owner-freebsd-current Sun Dec 17 22:36:59 2000 From owner-freebsd-current@FreeBSD.ORG Sun Dec 17 22:36:57 2000 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from critter.freebsd.dk (flutter.freebsd.dk [212.242.40.147]) by hub.freebsd.org (Postfix) with ESMTP id 09CD637B400; Sun, 17 Dec 2000 22:36:56 -0800 (PST) Received: from critter (localhost [127.0.0.1]) by critter.freebsd.dk (8.11.1/8.11.1) with ESMTP id eBI6atf25653; Mon, 18 Dec 2000 07:36:55 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: John Baldwin Cc: current@FreeBSD.ORG Subject: Re: test/review: /dev/console logging patch In-Reply-To: Your message of "Sun, 17 Dec 2000 15:04:56 PST." Date: Mon, 18 Dec 2000 07:36:55 +0100 Message-ID: <25651.977121415@critter> From: Poul-Henning Kamp Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message , John Baldwin writes: > >On 17-Dec-00 Poul-Henning Kamp wrote: >> >> This patch is for the printf(9), log(9) & /dev/console stuff. >> The result is that you can watch the output from /etc/rc in >> your /var/log/messages. >> >> Poul-Henning >> >> >> 1. Replace logwakeup() with msgbuftrigger++; There is little >> point in calling a function to set a flag. > >Abstraction to keep other code from having to know the iternals of the log(9) >device? Maybe use a #define for logwakeup() that does the msgbuftrigger++ to >keep the abstraction w/o the overhead? But it was actually the other way around now :-) It was the log device which had obfuscated the log/printf code because it needed it's assistance to call selwakeup. I want the log/printf code to be as simple as possible, and to have the smallest stack footprint possible... -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message