From owner-freebsd-doc@FreeBSD.ORG  Wed Dec 16 05:47:09 2009
Return-Path: <owner-freebsd-doc@FreeBSD.ORG>
Delivered-To: freebsd-doc@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 568DE106566C;
	Wed, 16 Dec 2009 05:47:09 +0000 (UTC)
	(envelope-from kurin@delete.org)
Received: from lithium.delete.org (lithium.delete.org [198.177.254.210])
	by mx1.freebsd.org (Postfix) with ESMTP id 377D98FC0A;
	Wed, 16 Dec 2009 05:47:08 +0000 (UTC)
Received: by lithium.delete.org (Postfix, from userid 1028)
	id C77DC7E84F; Wed, 16 Dec 2009 00:47:05 -0500 (EST)
Date: Wed, 16 Dec 2009 00:47:05 -0500
From: Toby Burress <kurin@delete.org>
To: Tom Rhodes <trhodes@FreeBSD.org>
Message-ID: <20091216054705.GB3748@lithium.delete.org>
References: <20091109184326.GG67127@lithium.delete.org>
	<20091109193952.1b8f790e.trhodes@FreeBSD.org>
	<20091110012610.GH67127@lithium.delete.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20091110012610.GH67127@lithium.delete.org>
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: freebsd-doc@FreeBSD.org
Subject: Re: ldap-auth article patch
X-BeenThere: freebsd-doc@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Documentation project <freebsd-doc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-doc>,
	<mailto:freebsd-doc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-doc>
List-Post: <mailto:freebsd-doc@freebsd.org>
List-Help: <mailto:freebsd-doc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-doc>,
	<mailto:freebsd-doc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Dec 2009 05:47:09 -0000

Resending this, as I guess it didn't make the list.

On Mon, Nov 09, 2009 at 08:26:10PM -0500, Toby Burress wrote:
> On Mon, Nov 09, 2009 at 07:39:52PM -0500, Tom Rhodes wrote:
> > Patch modified, please verify the original meaning by giving
> > my version a once over.
> 
> It looks like this was modified from my original ticket instead of
> the second patch I sent.  Either one is fine (they both catch the
> dimins.com -> example.org stuff, and yours additionally expands
> contractions).  However, in your patch there are two parenthetical
> statements which aren't closed.
> 
> 107c107
> < +# binds, there's probably some standard account you use for this.
> ---
> > +# binds, there's probably some standard account you use for this).
> 112c112
> < +# UID elsewhere in the tree; we don't want to return those.
> ---
> > +# UID elsewhere in the tree; we don't want to return those).
> 158a159
> 
> Other than that it looks fine.