From owner-freebsd-ports  Tue Aug 28 14:50:12 2001
Delivered-To: freebsd-ports@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id EF83337B403
	for <freebsd-ports@hub.freebsd.org>; Tue, 28 Aug 2001 14:50:05 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.4/8.11.4) id f7SLo5Z36498;
	Tue, 28 Aug 2001 14:50:05 -0700 (PDT)
	(envelope-from gnats)
Received: from alchemy.franken.de (alchemy.franken.de [194.94.249.140])
	by hub.freebsd.org (Postfix) with ESMTP
	id D584437B406; Tue, 28 Aug 2001 14:42:28 -0700 (PDT)
	(envelope-from corex@alchemy.franken.de)
Received: (from corex@localhost)
	by alchemy.franken.de (8.11.3/8.11.4/ALCHEMY.FRANKEN.DE) id f7SLonS55638;
	Tue, 28 Aug 2001 23:50:49 +0200 (CEST)
	(envelope-from corex)
Message-Id: <200108282150.f7SLonS55638@alchemy.franken.de>
Date: Tue, 28 Aug 2001 23:50:49 +0200 (CEST)
From: marius@alchemy.franken.de
Reply-To: marius@alchemy.franken.de
To: FreeBSD-gnats-submit@freebsd.org
Cc: nsayer@freebsd.org
X-Send-Pr-Version: 3.113
Subject: ports/30170: majordomo port: scripts/createuser does not add daemon to majordom-group when upgrading from a previous version
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-ports.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-ports>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-ports>
X-Loop: FreeBSD.org


>Number:         30170
>Category:       ports
>Synopsis:       majordomo port: scripts/createuser does not add daemon to majordom-group when upgrading from a previous version
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Aug 28 14:50:05 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator:     marius strobl
>Release:        FreeBSD 4.3-20010528-STABLE i386
>Organization:
>Environment:
System: FreeBSD alchemy.franken.de 4.3-20010528-STABLE FreeBSD 4.3-20010528-STABLE #0: Mon May 28 20:31:06 CEST 2001 root@alchemy.franken.de:/usr/obj/usr/bsd/build/4-stable/src/sys/alchemy i386


>Description:
	if the majordomo port is upgraded from an installed version not
	including the security fixes added on july 23, scripts/createuser
	bails out after finding the old majordomo user and group and does
	not add user daemon to majordomo group as required by the security
	fixes
	
>How-To-Repeat:
	upgrade an installed version of majordomo prior to july 23 by
	removing the old one and adding the current

>Fix:
	suggested patch:

--- createuser.orig	Mon Jul 23 18:14:02 2001
+++ createuser	Tue Aug 28 23:14:24 2001
@@ -24,7 +24,7 @@
 
 if( getgrnam( "majordom" ) ) {
 	$have_group = 1;
-	( $null, $null, $mjGID ) = getgrnam( "majordom" );
+	( $null, $null, $mjGID, $mjMEMBERS ) = getgrnam( "majordom" );
 } else {
 	$mjGID = 54;
 	while( getgrgid( $mjGID ) ) {
@@ -33,6 +33,13 @@
 }
 
 if( $have_group && $have_user ) {
+	if( $mjMEMBERS !~ /daemon/ ) {
+		$result = system( "pw groupmod majordom -m daemon" );
+		if( $result ) {
+        		print "Failed to modify user daemon!\n";
+        		exit 1;
+		}
+	}
 	exit 0;
 } elsif( $> ) {
 	print "\nYou must be root to run this step!\n\n";
@@ -64,6 +71,6 @@
 ## via direct pipes in /etc/mail/aliases
 $result = system( "pw groupmod majordom -m daemon" );
 if( $result ) {
-	print "Failed to add/modify user majordom!\n";
+	print "Failed to modify user daemon!\n";
 	exit 1;
 }
>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message