From owner-freebsd-current@FreeBSD.ORG  Sun Jun 21 08:20:37 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C0FDB1065672
	for <current@freebsd.org>; Sun, 21 Jun 2009 08:20:37 +0000 (UTC)
	(envelope-from rdivacky@vlk.vlakno.cz)
Received: from vlakno.cz (77-93-215-190.static.masterinter.net [77.93.215.190])
	by mx1.freebsd.org (Postfix) with ESMTP id 7A9FA8FC08
	for <current@freebsd.org>; Sun, 21 Jun 2009 08:20:37 +0000 (UTC)
	(envelope-from rdivacky@vlk.vlakno.cz)
Received: from localhost (localhost [127.0.0.1])
	by vlakno.cz (Postfix) with ESMTP id EC8EB9CB056
	for <current@freebsd.org>; Sun, 21 Jun 2009 10:20:24 +0200 (CEST)
X-Virus-Scanned: amavisd-new at vlakno.cz
Received: from vlakno.cz ([127.0.0.1])
	by localhost (lev.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id rfoay1HIpaCa for <current@freebsd.org>;
	Sun, 21 Jun 2009 10:20:22 +0200 (CEST)
Received: from vlk.vlakno.cz (localhost [127.0.0.1])
	by vlakno.cz (Postfix) with ESMTP id A12189CB10D
	for <current@freebsd.org>; Sun, 21 Jun 2009 10:20:22 +0200 (CEST)
Received: (from rdivacky@localhost)
	by vlk.vlakno.cz (8.14.3/8.14.3/Submit) id n5L8KMUX088625
	for current@freebsd.org; Sun, 21 Jun 2009 10:20:22 +0200 (CEST)
	(envelope-from rdivacky)
Date: Sun, 21 Jun 2009 10:20:22 +0200
From: Roman Divacky <rdivacky@freebsd.org>
To: current@freebsd.org
Message-ID: <20090621082022.GA88526@freebsd.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="WIyZ46R2i8wDzkSu"
Content-Disposition: inline
User-Agent: Mutt/1.4.2.3i
Cc: 
Subject: [PATCH]: if (cond); foo() in firewire
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 21 Jun 2009 08:20:37 -0000


--WIyZ46R2i8wDzkSu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

hi

is this patch correct? may I commit it?

Index: ../../../dev/firewire/fwdev.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- ../../../dev/firewire/fwdev.c       (revision 194573)
+++ ../../../dev/firewire/fwdev.c       (working copy)
@@ -443,7 +443,7 @@
        xfer->send.pay_len =3D uio->uio_resid;
        if (uio->uio_resid > 0) {
                if ((err =3D uiomove((caddr_t)&xfer->send.payload[0],
-                   uio->uio_resid, uio)));
+                   uio->uio_resid, uio)))
                        goto out;
        }
=20

another bug found by the "useless warnings in clang" ;)

roman

--WIyZ46R2i8wDzkSu
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.12 (FreeBSD)

iEYEARECAAYFAko97UYACgkQLVEj6D3CBEwJ+ACfc+s+GXxs+vHFZ6C0uFpFlh3X
9dkAnA4+I2l2Mpm40D8K0Xhh3x1uNuzY
=Fc1q
-----END PGP SIGNATURE-----

--WIyZ46R2i8wDzkSu--